Skip to content

Conversation

askpt
Copy link
Member

@askpt askpt commented Sep 11, 2025

Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com

This PR

This pull request makes a small change to the DisposeAsync method in MultiProvider.cs. After disposing of the semaphores, it now sets the _providerStatus to ProviderStatus.Fatal to ensure the provider's status accurately reflects its disposed state.

Related Issues

Fixes #569

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt askpt linked an issue Sep 11, 2025 that may be closed by this pull request
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.73%. Comparing base (db82a28) to head (79ec368).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files          64       64           
  Lines        2522     2523    +1     
  Branches      295      295           
=======================================
+ Hits         2263     2264    +1     
  Misses        199      199           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@askpt askpt marked this pull request as ready for review September 11, 2025 16:08
@askpt askpt requested a review from a team as a code owner September 11, 2025 16:08
@askpt askpt requested a review from Copilot September 11, 2025 16:09
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a status management issue in the MultiProvider by ensuring the provider status is properly set to Fatal when the provider is disposed. This change ensures that the provider's status accurately reflects its disposed state after cleanup.

  • Sets _providerStatus to ProviderStatus.Fatal after disposing semaphores in DisposeAsync method

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@kinyoklion
Copy link
Member

This doesn't appear thread-safe, but I assume that is a pre-existing issue, and probably needs addressed independently.

@askpt askpt added this pull request to the merge queue Sep 11, 2025
Merged via the queue into main with commit 76bd94b Sep 11, 2025
24 checks passed
@askpt askpt deleted the askpt/569-investigate-multi-provider-lifecycle-management branch September 11, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate multi-provider lifecycle management

3 participants