Skip to content

Conversation

lager95
Copy link
Contributor

@lager95 lager95 commented Jun 13, 2025

This PR

  • adds this new feature

Related Issues

Fixes #443

@lager95 lager95 requested a review from a team as a code owner June 13, 2025 11:17
@lager95 lager95 force-pushed the issue/nummeric-metadata branch 3 times, most recently from 5aa014b to b456089 Compare June 13, 2025 11:25
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (ce7baa7) to head (5077113).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #490      +/-   ##
==========================================
+ Coverage   90.04%   90.07%   +0.02%     
==========================================
  Files          77       77              
  Lines        2873     2881       +8     
  Branches      323      327       +4     
==========================================
+ Hits         2587     2595       +8     
  Misses        226      226              
  Partials       60       60              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…r decimals open-feature#443

Signed-off-by: Otto Lagerquist <otto_nr26@hotmail.com>
Signed-off-by: lager95 <33402278+lager95@users.noreply.github.com>
@lager95 lager95 force-pushed the issue/nummeric-metadata branch from b456089 to 51f1212 Compare June 13, 2025 11:50
Copy link

@alexandraoberaigner alexandraoberaigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@toddbaert toddbaert self-requested a review June 13, 2025 13:11
@toddbaert toddbaert requested review from askpt and benjiro June 13, 2025 13:11
@chrfwow
Copy link
Contributor

chrfwow commented Jun 25, 2025

It seems like you added a duplicate either to the PR title by accident

@lager95 lager95 changed the title feat: Support retrieving numeric metadata as either either integers or decimals feat: Support retrieving numeric metadata as either integers or decimals Jul 22, 2025
Updated document comments to reflect the conversions between int and double.

Signed-off-by: lager95 <33402278+lager95@users.noreply.github.com>
@lager95 lager95 force-pushed the issue/nummeric-metadata branch from 9505483 to 5034ea5 Compare July 22, 2025 13:38
@beeme1mr beeme1mr requested a review from a team August 25, 2025 15:37
@askpt askpt added this pull request to the merge queue Sep 22, 2025
Merged via the queue into open-feature:main with commit 12de5f1 Sep 22, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support retrieving numeric metadata as either either integers or decimals

9 participants