-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Support retrieving numeric metadata as either integers or decimals #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5aa014b
to
b456089
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #490 +/- ##
==========================================
+ Coverage 90.04% 90.07% +0.02%
==========================================
Files 77 77
Lines 2873 2881 +8
Branches 323 327 +4
==========================================
+ Hits 2587 2595 +8
Misses 226 226
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…r decimals open-feature#443 Signed-off-by: Otto Lagerquist <otto_nr26@hotmail.com> Signed-off-by: lager95 <33402278+lager95@users.noreply.github.com>
b456089
to
51f1212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉
It seems like you added a duplicate |
Updated document comments to reflect the conversions between int and double. Signed-off-by: lager95 <33402278+lager95@users.noreply.github.com>
9505483
to
5034ea5
Compare
This PR
Related Issues
Fixes #443