Skip to content

fix: Fix unit test clean context #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: Fix unit test clean context #313

merged 2 commits into from
Nov 11, 2024

Conversation

askpt
Copy link
Member

@askpt askpt commented Nov 11, 2024 •
edited
Loading

This PR

  • It fixes an issue where the context sometimes needs to be cleared correctly.
  • It should eliminate any further race conditions in the unit tests.

Notes

Following an investigation on xUnit shared contexts, I found we should use IDisposable to clear data between tests. See https://xunit.net/docs/shared-context for reference.

askpt added 2 commits November 11, 2024 11:52
@askpt
Adding the IDisposable xUnit pattern.
8a9ce81 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt
Changing to the dispose.
e4f8ce5 
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
@askpt askpt marked this pull request as ready for review November 11, 2024 12:21
@askpt askpt requested a review from a team as a code owner November 11, 2024 12:21
@toddbaert toddbaert merged commit 3038142 into main Nov 11, 2024
12 checks passed
@github-actions github-actions bot mentioned this pull request Nov 11, 2024
Closed
@askpt askpt deleted the askpt/fix-unit-test-sharing-data branch November 12, 2024 07:44
arttonoyan pushed a commit to arttonoyan/dotnet-sdk that referenced this pull request Nov 17, 2024
@askpt @arttonoyan
fix: Fix unit test clean context (open-feature#313)
d0b4a40 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- It fixes an issue where the context sometimes needs to be cleared
correctly.
- It should eliminate any further race conditions in the unit tests.

### Notes
<!-- any additional notes for this PR -->
Following an investigation on xUnit shared contexts, I found we should
use `IDisposable` to clear data between tests. See
https://xunit.net/docs/shared-context for reference.

---------

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: Artyom Tonoyan <artonoyan@servicetitan.com>
@github-actions github-actions bot mentioned this pull request Nov 18, 2024
Merged
toddbaert pushed a commit that referenced this pull request Nov 18, 2024
@github-actions
chore(main): release 2.1.0 (#320)
25bc54b 
🤖 I have created a release *beep* *boop*
---


##
[2.1.0](v2.0.0...v2.1.0)
(2024-11-18)


### 🐛 Bug Fixes

* Fix action syntax in workflow configuration
([#315](#315))
([ccf0250](ccf0250))
* Fix unit test clean context
([#313](#313))
([3038142](3038142))


### ✨ New Features

* Add Dependency Injection and Hosting support for OpenFeature
([#310](#310))
([1aaa0ec](1aaa0ec))


### 🧹 Chore

* **deps:** update actions/upload-artifact action to v4.4.3
([#292](#292))
([9b693f7](9b693f7))
* **deps:** update codecov/codecov-action action to v4.6.0
([#306](#306))
([4b92528](4b92528))
* **deps:** update dependency dotnet-sdk to v8.0.401
([#296](#296))
([0bae29d](0bae29d))
* **deps:** update dependency fluentassertions to 6.12.2
([#302](#302))
([bc7e187](bc7e187))
* **deps:** update dependency microsoft.net.test.sdk to 17.11.0
([#297](#297))
([5593e19](5593e19))
* **deps:** update dependency microsoft.net.test.sdk to 17.11.1
([#301](#301))
([5b979d2](5b979d2))
* **deps:** update dependency nsubstitute to 5.3.0
([#311](#311))
([87f9cfa](87f9cfa))
* **deps:** update dependency xunit to 2.9.2
([#303](#303))
([2273948](2273948))
* **deps:** update dotnet monorepo
([#305](#305))
([3955b16](3955b16))
* **deps:** update dotnet monorepo to 8.0.2
([#319](#319))
([94681f3](94681f3))
* update release please config
([#304](#304))
([c471c06](c471c06))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
askpt added a commit that referenced this pull request Dec 4, 2024
@askpt
fix: Fix unit test clean context (#313)
411beba 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- It fixes an issue where the context sometimes needs to be cleared
correctly.
- It should eliminate any further race conditions in the unit tests.

### Notes
<!-- any additional notes for this PR -->
Following an investigation on xUnit shared contexts, I found we should
use `IDisposable` to clear data between tests. See
https://xunit.net/docs/shared-context for reference.

---------

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
askpt pushed a commit that referenced this pull request Dec 4, 2024
@github-actions @askpt
chore(main): release 2.1.0 (#320)
9602aed 
🤖 I have created a release *beep* *boop*
---

##
[2.1.0](v2.0.0...v2.1.0)
(2024-11-18)

### 🐛 Bug Fixes

* Fix action syntax in workflow configuration
([#315](#315))
([ccf0250](ccf0250))
* Fix unit test clean context
([#313](#313))
([3038142](3038142))

### ✨ New Features

* Add Dependency Injection and Hosting support for OpenFeature
([#310](#310))
([1aaa0ec](1aaa0ec))

### 🧹 Chore

* **deps:** update actions/upload-artifact action to v4.4.3
([#292](#292))
([9b693f7](9b693f7))
* **deps:** update codecov/codecov-action action to v4.6.0
([#306](#306))
([4b92528](4b92528))
* **deps:** update dependency dotnet-sdk to v8.0.401
([#296](#296))
([0bae29d](0bae29d))
* **deps:** update dependency fluentassertions to 6.12.2
([#302](#302))
([bc7e187](bc7e187))
* **deps:** update dependency microsoft.net.test.sdk to 17.11.0
([#297](#297))
([5593e19](5593e19))
* **deps:** update dependency microsoft.net.test.sdk to 17.11.1
([#301](#301))
([5b979d2](5b979d2))
* **deps:** update dependency nsubstitute to 5.3.0
([#311](#311))
([87f9cfa](87f9cfa))
* **deps:** update dependency xunit to 2.9.2
([#303](#303))
([2273948](2273948))
* **deps:** update dotnet monorepo
([#305](#305))
([3955b16](3955b16))
* **deps:** update dotnet monorepo to 8.0.2
([#319](#319))
([94681f3](94681f3))
* update release please config
([#304](#304))
([c471c06](c471c06))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
kylejuliandev pushed a commit to kylejuliandev/dotnet-sdk that referenced this pull request Jan 9, 2025
@askpt @kylejuliandev
fix: Fix unit test clean context (open-feature#313)
259cdc6 
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

- It fixes an issue where the context sometimes needs to be cleared
correctly.
- It should eliminate any further race conditions in the unit tests.

### Notes
<!-- any additional notes for this PR -->
Following an investigation on xUnit shared contexts, I found we should
use `IDisposable` to clear data between tests. See
https://xunit.net/docs/shared-context for reference.

---------

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
kylejuliandev pushed a commit to kylejuliandev/dotnet-sdk that referenced this pull request Jan 9, 2025
@github-actions @kylejuliandev
chore(main): release 2.1.0 (open-feature#320)
acef282 
🤖 I have created a release *beep* *boop*
---

##
[2.1.0](open-feature/dotnet-sdk@v2.0.0...v2.1.0)
(2024-11-18)

### 🐛 Bug Fixes

* Fix action syntax in workflow configuration
([open-feature#315](open-feature#315))
([ccf0250](open-feature@ccf0250))
* Fix unit test clean context
([open-feature#313](open-feature#313))
([3038142](open-feature@3038142))

### ✨ New Features

* Add Dependency Injection and Hosting support for OpenFeature
([open-feature#310](open-feature#310))
([1aaa0ec](open-feature@1aaa0ec))

### 🧹 Chore

* **deps:** update actions/upload-artifact action to v4.4.3
([open-feature#292](open-feature#292))
([9b693f7](open-feature@9b693f7))
* **deps:** update codecov/codecov-action action to v4.6.0
([open-feature#306](open-feature#306))
([4b92528](open-feature@4b92528))
* **deps:** update dependency dotnet-sdk to v8.0.401
([open-feature#296](open-feature#296))
([0bae29d](open-feature@0bae29d))
* **deps:** update dependency fluentassertions to 6.12.2
([open-feature#302](open-feature#302))
([bc7e187](open-feature@bc7e187))
* **deps:** update dependency microsoft.net.test.sdk to 17.11.0
([open-feature#297](open-feature#297))
([5593e19](open-feature@5593e19))
* **deps:** update dependency microsoft.net.test.sdk to 17.11.1
([open-feature#301](open-feature#301))
([5b979d2](open-feature@5b979d2))
* **deps:** update dependency nsubstitute to 5.3.0
([open-feature#311](open-feature#311))
([87f9cfa](open-feature@87f9cfa))
* **deps:** update dependency xunit to 2.9.2
([open-feature#303](open-feature#303))
([2273948](open-feature@2273948))
* **deps:** update dotnet monorepo
([open-feature#305](open-feature#305))
([3955b16](open-feature@3955b16))
* **deps:** update dotnet monorepo to 8.0.2
([open-feature#319](open-feature#319))
([94681f3](open-feature@94681f3))
* update release please config
([open-feature#304](open-feature#304))
([c471c06](open-feature@c471c06))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert toddbaert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@askpt @beeme1mr @toddbaert