Update device-plugins to go 1.24.4 and drop 'mf' prefix #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byron-marohn
force-pushed
the
byron_initial_githubactions
branch
from
a8ebf48 to
675ca9f
Compare
byron-marohn
force-pushed
the
byron-device-plugin-go-ver
branch
from
f565f2b to
f5ede69
Compare
byron-marohn
force-pushed
the
byron_initial_githubactions
branch
from
675ca9f to
3430568
Compare
dmkarthi
approved these changes
Jun 20, 2025
| if [[ $? -ne 0 ]]; then | ||
| echo "Error: Failed to push the Docker image" | ||
| exit 1 | ||
| fi | ||
| fi | ||
|
|
||
| # Update the deployment manifest with the newly built image version | ||
| perl -p -i -e "s|image:.*mf-device-plugin:.*$|image: '$DOCKER_REPO/mf-device-plugin:$VER'|g" deploy/manifests/maverikflats-device-plugin.yaml | ||
| perl -p -i -e "s|image:.*device-plugin:.*$|image: '$DOCKER_REPO/device-plugin:$VER'|g" deploy/manifests/maverikflats-device-plugin.yaml |
There was a problem hiding this comment.
maverickflats again is internal code name..
Lets use : intel-idv-device-plugin
| @@ -1,7 +1,7 @@ | |||
| devicePlugin: | |||
| enabled: true | |||
| image: | |||
| repository: localhost:5000/mf-device-plugin | |||
| repository: localhost:5000/device-plugin | |||
There was a problem hiding this comment.
lets use intel-idv-device-plugin
…tions Initial github actions for automated build & security scans
Signed-off-by: Byron Marohn <byron.marohn@intel.com>
byron-marohn
force-pushed
the
byron-device-plugin-go-ver
branch
from
f5ede69 to
e10970e
Compare
|
Reopened this as #18, this PR had the wrong target branch. It was supposed to update to main once the parent was merged, but apparently didn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.