-
Notifications
You must be signed in to change notification settings - Fork 767
🚀 feat(model): add UniNet #2797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🚀 feat(model): add UniNet #2797
Conversation
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the implementation! Only few minor comments
@@ -1,6 +1,6 @@ | |||
"""PyTorch model defining the decoder network for Reverse Distillation. | |||
"""PyTorch model defining the decoder network for Reverse Distillation and UniNet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be an idea to have a better module name for this? de_resnet.py
never made sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resnet Transpose? Like ConvTranspose. I think de resnet was the name given by the authors of reverse distillation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resnet_decoder.py
could also work.- Would it make sense to rename
ResNet
toResNetDecoder
as well? - Also the docstring of
ResNet
should be updated with the correct imports I guess. The imports still show that the module is in reverse distillation
def learning_type(self) -> LearningType: | ||
"""The model uses one-class learning. | ||
|
||
Though technicaly it suppports multi-class and few_shot as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea how multi-class
and few-show
can work here?
Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Signed-off-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
📝 Description
uninet.yaml
does not work as Early Stopping from config is broken for all the models.Results
Combined
Original
Anomalib
Anomaly Map Examples
✨ Changes
Select what type of change your PR is:
✅ Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.