componentize #2
Open
componentize #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I made your project a component.
I moved the minified js from build to a new "dist" directory, because the component build defaults to build/ and it's different from the standalone build so it needed a different place.
Now xgui.js and xgui.min.js standalones are built with "make dist" using a combination of the component tool and the builder you had and they're put in dist/.
So it's backwards compatible but now it's also ready to be installed and used with the component tool. In the future, the elements and some utils could be extracted into their own files or modules and required into the main.
Also, great work! I love how these look and play. I'm certainly going to be using them in a project soon-ish.