make empty block deterministic #1287
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement offline witness in p2p * refactor local rpc * add rpc api * add license * fix comments * check self is gov node before vote
* remove old gov node ip from members in subnet * fix testcase
* Drop duplicate import * Drop redundant return and break statement * for true ==> for * Fix bool cmp lint should omit comparison to bool constant * use or drop unused variables * Drop empty branch * Some fmt.Sprintf is useless, drop it * should call self.quitWg.Add(1) before starting the goroutine to avoid a race * drop for, using append * Update cmd/tx_cmd.go * Update consensus/vbft/node_sync.go Co-authored-by: laizy <laizy@users.noreply.github.com>
laizy
force-pushed
the
master
branch
2 times, most recently
from
8c8ee59 to
dc599e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is straight forward, following is some compatible analysis about why it's safe to apply the fix.
VbftBlockInfo.Proposeris only ever retrieved(immutable referenced) by :blk.Infois only ever mutated by:BlockPool.setBlockSealed,Server.constructProposalMsg,Block.Deserialize:All of them will only set
blk.Infoto the non-empty one.initVbftBlock:This is only called after a block is sealed, so doesn't affect consensus.