Revised SurveyQC for Fucito #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from main 08/11
Made changes to match_answers_to_notifications to avoid unbound error
MMel099
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
Can you delete these .DS_Store files?
Might be worth implementing a .gitignore with all DS_Store and ipynb_checkpoint files (i.e. *.DS_Store)
| "source": [ | ||
| "# Uncomment the line below and use it to install any necessary packages.\n", | ||
| "#%pip install ..." | ||
| "%pip install matplotlib" |
There was a problem hiding this comment.
Can you add a %pip install -r requirements.txt and test from a totally fresh python environment to see what packages are needed.
| "!rm -rf $(find . -type d -name .ipynb_checkpoints)\n", | ||
| "\n", | ||
| "base_dir = \"raw_data\"\n", | ||
| "base_dir = \"files/raw_data\"\n", |
| " (schedule['BeiweID'] == beiwe_id) &\n", | ||
| " (schedule['DeliveredUTC'] < timestamp) & \n", | ||
| " (schedule['TruncatedUTC'] > timestamp)\n", | ||
| " (schedule['DeliveredUTC'] <= timestamp) & # inclusive bounds are usually safer\n", |
| " counts.loc[counts['BeiweID'] == beiwe_id, 'OutsideSubmissions'] += 1\n", | ||
| " print(f\"Submission outside of diary period: {file_path}\")\n", | ||
| " outside += 1\n", | ||
| " valid_row = False # <<< critical: don't treat as valid\n", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to match_answers_to_notifications to avoid unbound error