Skip to content

Conversation

@reyvababtista
Copy link
Collaborator

This PR adds OmniRing data storage feature into the backend. More information about OmniRing can be found here: https://www.cse.psu.edu/~mkg31/projects/omniring/

(cherry picked from commit 7c59e4c8fe5d9e5384ca225fd9ec32c7c7102623)
(cherry picked from commit a8cfed9f42a0adfbb42750af0b5ed0b774295294)
(cherry picked from commit 00a4c821085dbb93b0c0ed8d1020ebab01c0b618)
(cherry picked from commit ca1516b1d2e21d99f9c92adbe7512e411d436e8c)
(cherry picked from commit 824be169c6db70a8f22e3cbf9d075fc4047b587e)
@reyvababtista reyvababtista self-assigned this Nov 14, 2024
@biblicabeebli
Copy link
Member

I don't seem to be able to change the target branch..... hmmm....

@biblicabeebli biblicabeebli changed the base branch from scheduling-bugs to staged-updates March 4, 2025 16:31
@biblicabeebli
Copy link
Member

Ok, there we go, ui always throws me on that. Onto review!

@biblicabeebli
Copy link
Member

Generally looks fine, couple instances where I need you to clean up the scribbled-on whitespace.
One file I genuinely can only see whitespace changes in and need you to revert or tell me what changed.

I will need to stick a couple pieces behind a feature flag, handle a merge migration for anything other database changes since original merge request - I'll happily do that.

Making a new target branch for this so it doesn't go right to staging, we will target that branch, keep it up to date with staging.

I can revert the whitespace myself, I'd rather not, I do need you to get a handle on your IDE's aggressive autoformat. Cleanup is good, autoformat tools can be really helpful, aggressive autoformat is not because it screws up git history.

@biblicabeebli biblicabeebli changed the base branch from staged-updates to reyva/omniring March 4, 2025 16:55
@biblicabeebli
Copy link
Member

base updated to reyva/omniring, currently equal with staging.

@biblicabeebli
Copy link
Member

(trying to be helpful about your whitespace issues, might sound passive agressive, that is not the intent)

If you are using the command line for git diffs you can add this parameter (there is a third option, context, it seems.... dumb; and also a none ):

  • --ws-error-highlight=new,old

or you can permanently add it to your git config with

  • git config diff.wsErrorHighlight new,old
    (no idea if this is respected by non-cli interfaces, but it might be).

This setting will help you review whitespace in your diffs.
I recommend defaulting to a view that includes whitespace changes in your default view, and having a backup command line alias with --ws-error-highlight=none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants