-
Notifications
You must be signed in to change notification settings - Fork 48
Feature omniring #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: reyva/omniring
Are you sure you want to change the base?
Feature omniring #408
Conversation
(cherry picked from commit 7c59e4c8fe5d9e5384ca225fd9ec32c7c7102623)
(cherry picked from commit a8cfed9f42a0adfbb42750af0b5ed0b774295294)
(cherry picked from commit 00a4c821085dbb93b0c0ed8d1020ebab01c0b618)
(cherry picked from commit ca1516b1d2e21d99f9c92adbe7512e411d436e8c)
(cherry picked from commit 824be169c6db70a8f22e3cbf9d075fc4047b587e)
|
I don't seem to be able to change the target branch..... hmmm.... |
|
Ok, there we go, ui always throws me on that. Onto review! |
|
Generally looks fine, couple instances where I need you to clean up the scribbled-on whitespace. I will need to stick a couple pieces behind a feature flag, handle a merge migration for anything other database changes since original merge request - I'll happily do that. Making a new target branch for this so it doesn't go right to staging, we will target that branch, keep it up to date with staging. I can revert the whitespace myself, I'd rather not, I do need you to get a handle on your IDE's aggressive autoformat. Cleanup is good, autoformat tools can be really helpful, aggressive autoformat is not because it screws up git history. |
|
base updated to |
|
(trying to be helpful about your whitespace issues, might sound passive agressive, that is not the intent) If you are using the command line for git diffs you can add this parameter (there is a third option,
or you can permanently add it to your git config with
This setting will help you review whitespace in your diffs. |
This PR adds OmniRing data storage feature into the backend. More information about OmniRing can be found here: https://www.cse.psu.edu/~mkg31/projects/omniring/