-
Notifications
You must be signed in to change notification settings - Fork 128
Refactored fcl-core exec folder files to TypeScript #2473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored fcl-core exec folder files to TypeScript #2473
Conversation
|
packages/fcl-core/src/exec/mutate.ts
Outdated
import type {AccountAuthorization} from "@onflow/sdk" | ||
import {StorageProvider} from "../utils/storage" | ||
|
||
// TODO: Substitute with CurrentUser interface from current-user refactoring once merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which pr needs to be reviewed first to unblock this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one #2454
packages/fcl-core/src/exec/mutate.ts
Outdated
|
||
export interface MutateOptions { | ||
cadence?: string | ||
args?: ArgsFn | any[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is any[]
needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatibility with other not yet refactored folders, cleaned all up now!
packages/fcl-core/src/exec/mutate.ts
Outdated
export interface MutateOptions { | ||
cadence?: string | ||
args?: ArgsFn | any[] | ||
template?: string | any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is any
needed here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compatibility with other not yet refactored folders, cleaned all up now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 more Qs, rest LGTM
packages/fcl-core/src/exec/query.ts
Outdated
template?: string | any | ||
isSealed?: boolean | ||
limit?: number | ||
[key: string]: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the same thing apply here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, updated and improved!
export interface PreOptions { | ||
cadence?: string | ||
template?: any | ||
[key: string]: any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the same thing apply here? Or is this different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, updated and improved!
Closes #2447