Skip to content

Refactored fcl-core exec folder files to TypeScript #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 11, 2025

Conversation

mfbz
Copy link
Contributor

@mfbz mfbz commented May 26, 2025

Closes #2447

@mfbz mfbz requested a review from a team as a code owner May 26, 2025 21:30
Copy link

changeset-bot bot commented May 26, 2025

⚠️ No Changeset found

Latest commit: 33b17bf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

import type {AccountAuthorization} from "@onflow/sdk"
import {StorageProvider} from "../utils/storage"

// TODO: Substitute with CurrentUser interface from current-user refactoring once merged
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which pr needs to be reviewed first to unblock this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one #2454

@mfbz mfbz requested a review from chasefleming June 5, 2025 17:28
@mfbz mfbz requested a review from jribbink June 10, 2025 22:42

export interface MutateOptions {
cadence?: string
args?: ArgsFn | any[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is any[] needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility with other not yet refactored folders, cleaned all up now!

export interface MutateOptions {
cadence?: string
args?: ArgsFn | any[]
template?: string | any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is any needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility with other not yet refactored folders, cleaned all up now!

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more Qs, rest LGTM

@mfbz mfbz requested a review from jribbink June 11, 2025 07:21
template?: string | any
isSealed?: boolean
limit?: number
[key: string]: any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the same thing apply here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, updated and improved!

export interface PreOptions {
cadence?: string
template?: any
[key: string]: any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the same thing apply here? Or is this different

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, updated and improved!

@mfbz mfbz requested a review from jribbink June 11, 2025 19:39
@mfbz mfbz merged commit 3252090 into feature/typescript-fcl-core Jun 11, 2025
1 check passed
@mfbz mfbz deleted the mfbz/refactor-fcl-core-exec branch June 11, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants