Update token guides for Cadence 1.0 #787
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
joshuahannan
requested review from
sisyphusSmiling,
chasefleming and
nialexsan
and removed request for
sisyphusSmiling and
chasefleming
|
@chasefleming I opened PRs in your repos with the changes from these guides:
Can you please review this PR and those two PRs so we can get everything merged an updated? Thanks! |
| @@ -17,22 +17,55 @@ Fungible tokens are digital assets that are interchangeable and indistinguishabl | |||
|
|
|||
| ## Vaults on Flow | |||
|
|
|||
| On the Flow blockchain, fungible tokens are stored in structures called vaults. Think of a vault as a digital piggy bank. When you transfer tokens from one vault to another: | |||
| On the Flow blockchain and in the Cadence programming language, | |||
| fungible tokens are stored in structures called resources. | |||
There was a problem hiding this comment.
Looks like there are line breaks here when they shouldn't be.
There was a problem hiding this comment.
We've always had a policy at Flow (at least in the Cadence and protocol teams), that we keep lines in docs at <100 characters because it makes it easier to leave comments and suggestions for the docs in code reviews. I thought it was also a policy in the Devex team too, but maybe it was forgotten about. I prefer to keep it this way
|
@chasefleming I addressed your comments and pushed some new changes. As I said in my reply, the line break thing was intentional, so don't worry about that |
Updates the ft, nft, and metadata views guides for Cadence 1.0
I'm currently working on updating Chase's example repos, so those should be ready soon.
I'm hoping to get a review on this first though in case there are any changes I need to make to the code