Cadence 1.0 #739
Cadence 1.0 #739
Conversation
replace pub(set) with access(all)
* destroy event handler * replace destroy with resource destroy event * fix contract name * format
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This looks good to me! Pub updates are really straight forward. Would just update the wording a bit so its clear, something along the lines of, "The HelloWorld contract exposes a public variable named greeting that is accessible to everything outside the function." 
|
There was a problem hiding this comment.
Are these the auto-generated docs for MetadataViews? They are out of date with the Cadence 1.0 versions of the standard. For example, Resolver and ResolverCollection have been moved to ViewResolver
There was a problem hiding this comment.
We probably should rework this whole section. Not sure why there are individual files for each view
There was a problem hiding this comment.
yes, these were autogenerated, I removed them
There was a problem hiding this comment.
I also think this section should be deleted
There was a problem hiding this comment.
these were autogenerated and left after moving them around, I deleted them
|
Probably would be good for me to just go through the FT and NFT guides to update them to the correct code though |
|
@nialexsan Can you tag me when you've addressed all my comments that aren't about the nft and ft guides? Once you're done with those, I'll just make a branch based of your branch and just work on a complete overhaul of the guides for Cadence 1.0. Hoping to start early next week if possible |
|
@nialexsan have you been able to address my non-guide comments yet? I'd like to pull this branch down and work on the guide stuff soon |
|
@joshuahannan |
#531