Be less strict with timer test #2547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
force-pushed
the
ross/timerstrict
branch
3 times, most recently
from
5856126 to
16c81b3
Compare
github-actions
bot
added
specification
RossBrunton
force-pushed
the
ross/timerstrict
branch
2 times, most recently
from
680d5d9 to
fcd33f1
Compare
RossBrunton
removed
specification
The `SuccessSynchronizedTime` previously sampled for several hundred nanoseconds in order to detect clock drift. This is too strict, and so it has been increased to 16ms.
RossBrunton
force-pushed
the
ross/timerstrict
branch
from
fcd33f1 to
cf0c1f0
Compare
pbalcer
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SuccessSynchronizedTimepreviously sampled for several hundrednanoseconds in order to detect clock drift. This is too strict, and so
it has been increased to 16ms.