Skip to content

[v0.11.x] Bump UMF to v0.10.1 patch release #2537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Jan 9, 2025

It contains 2 significant fixes:

  • Setting symbols' versioning, which will help preventing breaking changes
  • Removing incorrect assert in utils_align_ptr_up_size_down

At best, this would go to v0.11.x, but I'm not sure of the current state of releasing this branch...?

@lukaszstolarczuk lukaszstolarczuk added the v0.11.x Include in the v0.11.x release label Jan 9, 2025
@github-actions github-actions bot added the common Changes or additions to common utilities label Jan 9, 2025
It contains 2 significant fixes:
- Setting symbols' versioning, which will help preventing breaking changes
- Removing incorrect assert in utils_align_ptr_up_size_down
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review January 10, 2025 13:13
@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner January 10, 2025 13:13
@lukaszstolarczuk
Copy link
Contributor Author

undrafted, ready for review.

I tried to verify this PR on llvm repo, but they are already moved on to using UR from main... so my PR is doomed to fail...? Any hints what would be the best approach at the moment...? ping @oneapi-src/unified-runtime-maintain

@kbenzie
Copy link
Contributor

kbenzie commented Jan 10, 2025

undrafted, ready for review.

I tried to verify this PR on llvm repo, but they are already moved on to using UR from main... so my PR is doomed to fail...? Any hints what would be the best approach at the moment...? ping @oneapi-src/unified-runtime-maintain

There's a few things to consider here:

  1. We need to have these changes reflected in UR main and therefore intel/llvm as well before we can merged to v0.11.x release branch. Would this involve divergent UMF branches?
  2. There needs to be a Jira (likely high exposure) associated with any bug fixes before they can be included in the internal release.
  3. This will trigger a number of cherry-picks to be included in the internal release.

@lukaszstolarczuk
Copy link
Contributor Author

Thanks @kbenzie

I've discussed this PR with the team and I believe it's not crucial to have this one in v0.11.x

@lukaszstolarczuk lukaszstolarczuk deleted the bump-umf-v0.10.1 branch January 13, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Changes or additions to common utilities v0.11.x Include in the v0.11.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants