Skip to content

[L0 v2] use UMF in urUSMGetMemAllocInfo #2473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

igchor
Copy link
Member

@igchor igchor commented Dec 17, 2024

No description provided.

@igchor igchor requested review from a team as code owners December 17, 2024 02:00
@igchor
Copy link
Member Author

igchor commented Dec 17, 2024

@pbalcer this also bumps the UMF version. Is it OK to do this now (and in this PR?)?

@github-actions github-actions bot added common Changes or additions to common utilities conformance Conformance test suite issues. level-zero L0 adapter specific issues labels Dec 17, 2024
This avoid going to the driver and speeds up
UR_USM_ALLOC_INFO_DEVICE query ~2 times in a microbenchmark.
@pbalcer
Copy link
Contributor

pbalcer commented Dec 17, 2024

@pbalcer this also bumps the UMF version. Is it OK to do this now (and in this PR?)?

Depends on whether there were any breaking changes between current and latest version. If there weren't, then it's fine.

@igchor
Copy link
Member Author

igchor commented Dec 17, 2024

@pbalcer this also bumps the UMF version. Is it OK to do this now (and in this PR?)?

Depends on whether there were any breaking changes between current and latest version. If there weren't, then it's fine.

The umf_memory_provider_ops_t was modified (oneapi-src/unified-memory-framework@3112e2b), and I believe this is a breaking change. I'll convert the PR to draft until it's safe to bump the UMF.

@igchor igchor marked this pull request as draft December 17, 2024 17:13
@pbalcer
Copy link
Contributor

pbalcer commented Jan 14, 2025

This is blocked by #2546

@martygrant
Copy link
Contributor

Unified Runtime -> intel/llvm Repo Move Notice

Information

The source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory,
all future development will now be carried out there. This was done in intel/llvm#17043.

The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime.

The contribution guide has been updated with new instructions for contributing to Unified Runtime.

PR Migration

All open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days.
To allow for some breathing space, this automation will not be enabled until next week (27/02/2025).

Should you wish to continue with your PR you will need to migrate it to intel/llvm.
We have provided a script to help automate this process.


This is an automated comment.

@igchor igchor closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Changes or additions to common utilities conformance Conformance test suite issues. level-zero L0 adapter specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants