Skip to content

Fix: add missing header stdexcept in benchmark/multithread.hpp #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Oct 14, 2024

Description

Fix: add missing header <stdexcept> in benchmark/multithread.hpp

It fixes the following build error:

In file included from /home/runner/work/unified-memory-framework/unified-memory-framework/benchmark/multithread.cpp:10:
/home/runner/work/unified-memory-framework/unified-memory-framework/benchmark/multithread.hpp: In function ‘auto umf_bench::measure(size_t, size_t, F&&)’:
/home/runner/work/unified-memory-framework/unified-memory-framework/benchmark/multithread.hpp:42:20: error: ‘runtime_error’ is not a member of ‘std’
   42 |         throw std::runtime_error("iterations must be > 1");
      |                    ^~~~~~~~~~~~~
/home/runner/work/unified-memory-framework/unified-memory-framework/benchmark/multithread.hpp:24:1: note: ‘std::runtime_error’ is defined in header ‘<stdexcept>’; did you forget to ‘#include <stdexcept>’?
   23 | #include "multithread_helpers.hpp"
  +++ |+#include <stdexcept>
   24 | 

See: https://github.com/ldorau/unified-memory-framework/actions/runs/11323579534/job/31486568812

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau ldorau requested a review from a team as a code owner October 14, 2024 08:26
@lukaszstolarczuk lukaszstolarczuk merged commit 0cac080 into oneapi-src:main Oct 14, 2024
72 checks passed
@ldorau ldorau deleted the Fix_add_missing_header_stdexcept_in_benchmark_multithread.hpp branch October 14, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants