Fix: add some missing *_LIBRARY_DIRS to target_link_directories() #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following examples: - umf_example_ipc_ipcapi_anon_fd - umf_example_ipc_ipcapi_shm - umf_example_custom_file_provider require TBB and they have to know TBB_LIBRARY_DIRS. The umf_example_dram_and_fsdax example requires HWLOC and it has to know LIBHWLOC_LIBRARY_DIRS. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
lukaszstolarczuk
approved these changes
Oct 9, 2024
bratpiorka
approved these changes
Oct 9, 2024
ldorau
deleted the
Fix_add_some_missing_LIBRARY_DIRS_to_target_link_directories
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix: add some missing
*_LIBRARY_DIRStotarget_link_directories():The following examples:
umf_example_ipc_ipcapi_anon_fdumf_example_ipc_ipcapi_shmumf_example_custom_file_providerrequire TBB and they have to know
TBB_LIBRARY_DIRS.The
umf_example_dram_and_fsdaxexample requires HWLOC and it has to knowLIBHWLOC_LIBRARY_DIRS.Checklist