Skip to content

Implement purge_lazy/_force() API of the Coarse provider #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Oct 8, 2024

Description

Implement purge_lazy/_force() API of the Coarse provider.
Tests for the new API are included in #815.

Requires:

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau force-pushed the Implement_purge_lazy_force_API_of_the_Coarse_provider branch 4 times, most recently from 94eb254 to b2b5e95 Compare October 17, 2024 19:28
@ldorau
Copy link
Contributor Author

ldorau commented Oct 17, 2024

A test added: test/pools/pool_coarse_file.cpp

@ldorau ldorau force-pushed the Implement_purge_lazy_force_API_of_the_Coarse_provider branch 5 times, most recently from 3c9d06b to caa3be0 Compare October 21, 2024 19:07
@ldorau
Copy link
Contributor Author

ldorau commented Oct 22, 2024

Tests for the new API are included in #815.

@ldorau
Copy link
Contributor Author

ldorau commented Oct 22, 2024

Overall coverage rate:
lines......: 80.3% (4586 of 5708 lines)
https://github.com/oneapi-src/unified-memory-framework/actions/runs/11446915065

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau ldorau force-pushed the Implement_purge_lazy_force_API_of_the_Coarse_provider branch from caa3be0 to 45806bb Compare October 22, 2024 11:48
@ldorau ldorau marked this pull request as ready for review October 22, 2024 11:48
@ldorau ldorau requested a review from a team as a code owner October 22, 2024 11:48
@ldorau
Copy link
Contributor Author

ldorau commented Oct 22, 2024

PR is ready for review.

@ldorau
Copy link
Contributor Author

ldorau commented Oct 22, 2024

Tests for the new API were added in #815.

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau
Copy link
Contributor Author

ldorau commented Oct 22, 2024

More tests added

@ldorau ldorau requested a review from bratpiorka October 22, 2024 17:12
@ldorau
Copy link
Contributor Author

ldorau commented Oct 22, 2024

@bratpiorka PR is ready for review, tests added.

@lukaszstolarczuk lukaszstolarczuk merged commit e060b6d into oneapi-src:main Oct 23, 2024
75 checks passed
@ldorau ldorau deleted the Implement_purge_lazy_force_API_of_the_Coarse_provider branch October 23, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants