open_ipc_handle should use shm from handle #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_ipc_shm_fix
branch
from
e45efa6 to
cb33da3
Compare
ldorau
requested changes
Oct 8, 2024
bratpiorka
force-pushed
the
rrudnick_ipc_shm_fix
branch
from
cb33da3 to
1e9be07
Compare
ldorau
approved these changes
Oct 8, 2024
vinser52
reviewed
Oct 8, 2024
vinser52
reviewed
Oct 8, 2024
bratpiorka
force-pushed
the
rrudnick_ipc_shm_fix
branch
2 times, most recently
from
288d679 to
8f889e7
Compare
bratpiorka
force-pushed
the
rrudnick_ipc_shm_fix
branch
from
8f889e7 to
46f6eef
Compare
ldorau
approved these changes
Oct 8, 2024
vinser52
approved these changes
Oct 8, 2024
lplewa
requested changes
Oct 8, 2024
bratpiorka
force-pushed
the
rrudnick_ipc_shm_fix
branch
from
46f6eef to
7e81e7e
Compare
lplewa
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open_ipc_handle should use shm from handle
see #777 for details