check for null dereference in trackingOpenIpcHandle #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
reviewed
Apr 8, 2024
| @@ -586,17 +586,23 @@ static umf_result_t trackingOpenIpcHandle(void *provider, void *providerIpcData, | |||
| (umf_tracking_memory_provider_t *)provider; | |||
| umf_result_t ret = UMF_RESULT_SUCCESS; | |||
|
|
|||
| if (p->hUpstream == NULL) { | |||
There was a problem hiding this comment.
How it is possible? If it happens it indicates error in UMF code, right? If so, I think it should be just assert.
I agree that && p->hUpstream checks below should be just removed.
There was a problem hiding this comment.
This is just a fix for coverity. Agree that this should never happen but I think it is better to add this code that add a false-positive
There was a problem hiding this comment.
IMHO if it is really a false-positive it is much better to ignore it in Coverity than add a redundant code.
There was a problem hiding this comment.
@bratpiorka I propose sth like that #420 instead and ignore this issue in Coverity.
|
this would be fixed by #420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for null dereference in trackingOpenIpcHandle - this is a fix for coverity issue https://scan3.scan.coverity.com/#/project-view/65229/15141?selectedIssue=453142
Checklist