Skip to content

Add IPC example with Level 0 provider #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

vinser52
Copy link
Contributor

@vinser52 vinser52 commented Apr 8, 2024

Description

This PR adds an example to demonstrate UMF IPC API. Level 0 memory provider is used for demonstration purposes since it is the only provider we have so far that supports IPC functionality.

Ref. #413

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • Extended the README
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files

@vinser52 vinser52 requested a review from a team as a code owner April 8, 2024 13:28

#include <level_zero/ze_api.h>

static int init_level_zero() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bratpiorka I think these utility functions can be re-used in the Level Zero provider unit tests. But we can do it in a separate PR.

@vinser52
Copy link
Contributor Author

vinser52 commented Apr 8, 2024

Need to coordinate with #384

@bratpiorka
Copy link
Contributor

@vinser52 vinser52 force-pushed the svinogra_ipc_api branch 5 times, most recently from ce4b4a5 to 7d1e129 Compare April 11, 2024 13:28
@vinser52 vinser52 marked this pull request as draft April 12, 2024 10:51
@vinser52 vinser52 linked an issue Apr 12, 2024 that may be closed by this pull request
@vinser52
Copy link
Contributor Author

I want to extend the documentation with more detailed example description.

@bratpiorka
Copy link
Contributor

I want to extend the documentation with more detailed example description.

in this or separate PR? if this please make it a draft

@vinser52
Copy link
Contributor Author

I want to extend the documentation with more detailed example description.

in this or separate PR? if this please make it a draft

in this PR. And it is already a Draft.

@vinser52 vinser52 marked this pull request as ready for review April 17, 2024 14:10
@vinser52
Copy link
Contributor Author

vinser52 commented Apr 17, 2024

@bratpiorka Ready for review. I updated the example documentation.

Generated docs preview: https://vinser52.github.io/unified-memory-framework/examples.html#ipc-example-with-level-zero-memory-provider

@bratpiorka
Copy link
Contributor

@vinser52 great, I like it

@bratpiorka bratpiorka merged commit 167898c into oneapi-src:main Apr 22, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create IPC example
5 participants