Enable tests of proxy library on Windows Debug #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_proxy_lib_new_delete.h
branch
from
4a1311c to
8bffca8
Compare
ldorau
changed the title
bratpiorka
requested changes
Apr 8, 2024
PatKamin
approved these changes
Apr 8, 2024
ldorau
force-pushed
the
Add_proxy_lib_new_delete.h
branch
2 times, most recently
from
1a9c70f to
67e40fb
Compare
bratpiorka
reviewed
Apr 8, 2024
bratpiorka
reviewed
Apr 8, 2024
ldorau
force-pushed
the
Add_proxy_lib_new_delete.h
branch
3 times, most recently
from
c744754 to
04bdc1e
Compare
|
Converting to draft, because of license issues. Please review anyway. |
igchor
reviewed
Apr 8, 2024
| In case of Windows it requires: | ||
| 1) explicitly linking your program dynamically with the `umf_proxy.dll` library | ||
| 2) (C++ code only) including `proxy_lib_new_delete.h` in a single(!) source file in your project | ||
| to override also the `new`/`delete` operations. |
There was a problem hiding this comment.
If the user is supposed to include proxy_lib_new_delete.h then it should be in include dir, not src and we should install it along other headers.
There was a problem hiding this comment.
@igchor I checked that this new file is properly installed
ldorau
force-pushed
the
Add_proxy_lib_new_delete.h
branch
from
04bdc1e to
7306c81
Compare
Add Microsoft aligned variants to Windows proxy library: - _aligned_malloc() - _aligned_realloc() - _aligned_recalloc() - _aligned_msize() - _aligned_free() - _aligned_offset_malloc() - _aligned_offset_realloc() - _aligned_offset_recalloc() and remove _free_dbg(). Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
This header provides convenient overrides for the new and delete operations in C++. It should be included in only one source file. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Fixes: oneapi-src#350 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
This reverts commit 92fa419. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau
force-pushed
the
Add_proxy_lib_new_delete.h
branch
from
7306c81 to
56d93ed
Compare
|
PR is ready for re-review. |
bratpiorka
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
_aligned_malloc()and_aligned_free()to Windows proxy library._aligned_malloc()is a Windows variant of Linuxaligned_alloc()Add proxy_lib_new_delete.h
This header provides convenient overrides for the new and delete
operations in C++. It should be included in only one source file.
See: https://github.com/microsoft/mimalloc/tree/8f7d1e9a41bb0182166aac6a8d4d8b00f60ed032?tab=readme-ov-file#override_on_windows
Fixes: The proxy library does not work in the Debug build on Windows #350
Revert "Disable proxy lib tests on Windows Debug"
This reverts commit 92fa419.
Checklist