Build pool libs as shared if umf is shared also #388
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_shared_pools
branch
10 times, most recently
from
36a7e01 to
c8dd8bd
Compare
bratpiorka
force-pushed
the
rrudnick_shared_pools
branch
4 times, most recently
from
0bf0e43 to
9424202
Compare
What is the reason for that? |
I think we should either provide all libs as shared objects or none. Please think about what we will install in oneAPI toolkit. The discussion is here: #387 |
bratpiorka
force-pushed
the
rrudnick_shared_pools
branch
from
9424202 to
e76cc25
Compare
|
closing this as we agreed in #387. that we don't want this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build memory pool libs (disjoint, scalable, etc.) as shared if the main libumf is also built as shared lib.
Ref: #387
Checklist