Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an example for combination of Disjoint Pool and L0 #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an example for combination of Disjoint Pool and L0 #384
Changes from all commits
474fdc4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message is incorrect. Please fix it to include build GPU examples variable.
(BTW do we really need "UMF_BUILD_GPU_EXAMPLES" variable - imho if all dependencies are ON, we should build it by default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second the question - do we need extra
UMF_BUILD_GPU_EXAMPLES
option? We could enable testing this example ifUMF_BUILD_GPU_TESTS
is ON.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing (what we actually run) has nothing to do with the build options.
UMF_BUILD_GPU_TESTS
is used for building, not testing. If you want to extend this flag, rename itUMF_BUILD_GPU_TESTS_AND_EXAMPLES
orUMG_BUILD_GPU_CODE
etc. I agree that we could do some cleanup in build flags - could we address this in additional PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I'm saying, is we could (as Łukasz stated above) build it all the time, as long as L0_PROVIDER is ON. We don't need this new flag just for building.
Nontheless, I guess, we could clean flags separately later on...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need a dedicated cmake option for GPU examples (UMF_BUILD_GPU_EXAMPLES). After the #427 is implemented we will have examples that will be installed with a pre-built version of UMF. So customer needs an option to disable/enable GPU examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this extra flag is not needed as when it is turned
ON
but the two other flags are not, nothing happens. I think that existing flagUMF_BUILD_EXAMPLES
suffices. If the user wants to have examples build, then all examples for a given config options set will be built.As it is now, the user would have to set both
UMF_BUILD_EXAMPLES
andUMF_BUILD_GPU_EXAMPLES
flags to build this example. Seeing these two options in CMake I would expect that only the second one is needed for building the GPU examples.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that all changes around cmake files, flags and folders could be done as a part of #427