Minor CI changes #1321
Merged
Minor CI changes #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszstolarczuk
force-pushed
the
ci-changes
branch
3 times, most recently
from
23afae3 to
d1a3e8c
Compare
bratpiorka
approved these changes
May 20, 2025
PatKamin
reviewed
May 20, 2025
| @@ -25,7 +25,7 @@ on: | |||
| compatibility: | |||
| required: false | |||
| type: string | |||
| default: 0 | |||
| default: '0' | |||
There was a problem hiding this comment.
Fix also passed compatibility argument in the sycl compat nightly job, please
There was a problem hiding this comment.
for a reason this was not considered an issue in my linter, but changed it for unity - thx!
PatKamin
approved these changes
May 20, 2025
look only for the actual nigthly releases. The "regular release" may be incompatible, as they may be in regard to older codebase.
lukaszstolarczuk
force-pushed
the
ci-changes
branch
from
d1a3e8c to
fa17e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes update for nightly sycl build, to avoid: https://github.com/oneapi-src/unified-memory-framework/actions/runs/15104034834/job/42449512722#step:3:12
The issue above was caused by a sycl release, which:
// preview of nightly job: https://github.com/oneapi-src/unified-memory-framework/actions/runs/15116081326?pr=1321