Add dockers to Fast and Basic Builds #1298

rbanka1 · 2025-05-06T15:26:57Z

Added UMF docker

// workflow executed on fork:
https://github.com/rbanka1/unified-memory-framework/actions/runs/15134054789
https://github.com/rbanka1/unified-memory-framework/actions/runs/15134054814

I added a new Docker image for Ubuntu 24.04 and updated the others.
I also created two new workflows that check for changes in the Docker files.
If any changes are detected, the relevant Docker image will be rebuilt and pushed (unless it's a pull request).
The rebuilt images will be available after the merge.

KFilipek · 2025-05-07T13:17:07Z

@lukaszstolarczuk
We have https://github.com/bb-umf account on GitHub.

KFilipek · 2025-05-07T13:28:58Z

.github/docker/ubuntu-20.04.Dockerfile


 # Dependencies for tests (optional)
 ARG TEST_DEPS="\
-	libnuma-dev"
+	libnuma-dev \
+	libtbb-dev\


Scalable pool relies on TBB library (src/pool/pool_scalable.c), so this is an UMF dependency.

The same as for libnuma - as long as you don't use that pool it's not required. Hence, I'd leave as test deps.

KFilipek · 2025-05-07T13:30:33Z

.github/docker/ubuntu-20.04.Dockerfile


 # Dependencies for tests (optional)
 ARG TEST_DEPS="\
-	libnuma-dev"
+	libnuma-dev \


It's requirement for OS memory provider, according to README.md

As mentioned in the readme, it's for testing :)

While I agree with you that for runtime this is a requirement, it is not the hard requirement. As long as you don't use that provider it's not really required, hence we only mark this as "for testing" (or, in the user's case - for the application that uses the provider).

I'd personally leave libnuma as test deps.

KFilipek · 2025-05-07T13:35:11Z

.github/workflows/reusable_basic.yml


 env:
  BUILD_DIR : "${{github.workspace}}/build"
-  INSTL_DIR : "${{github.workspace}}/install-dir"
+  INSTL_DIR : "${{github.workspace}}/../install-dir"


I believe going outside the workspace is not the best idea.

…-framework into newDocker

lukaszstolarczuk · 2025-05-14T11:01:59Z

.github/docker/ubuntu-20.04.Dockerfile

@@ -1,10 +1,10 @@
-# Copyright (C) 2024 Intel Corporation
+# Copyright (C) 2024-2025 Intel Corporation


pls order commits and add a proper commit title/message; while we're adding one new docker, the main change is something else 😉

pls also update the title of the PR, and if ready, please un-draft

commits still to be ordered + proper commit msg

.github/docker/ubuntu-22.04.Dockerfile

.github/docker/ubuntu-20.04.Dockerfile

.github/workflows/reusable_basic.yml

lukaszstolarczuk · 2025-05-14T11:14:53Z

.github/workflows/reusable_basic.yml

@@ -192,7 +166,6 @@ jobs:
        -DUMF_DISABLE_HWLOC=${{matrix.disable_hwloc}}
        -DUMF_LINK_HWLOC_STATICALLY=${{matrix.link_hwloc_statically}}
        ${{ matrix.build_type == 'Debug' && matrix.compiler.c == 'gcc' && '-DUMF_USE_COVERAGE=ON' || '' }}
-        ${{ matrix.llvm_linker || '' }}


why this is removed?

.github/workflows/reusable_basic.yml

lukaszstolarczuk · 2025-05-21T13:33:14Z

.github/docker/ubuntu-20.04.Dockerfile

@@ -1,10 +1,10 @@
-# Copyright (C) 2024 Intel Corporation
+# Copyright (C) 2024-2025 Intel Corporation


commits still to be ordered + proper commit msg

.github/docker/ubuntu-22.04.Dockerfile

lukaszstolarczuk · 2025-05-21T13:38:38Z

.github/workflows/pr_push.yml


 jobs:
  CodeChecks:
    uses: ./.github/workflows/reusable_checks.yml
  FastBuild:
-    name: Fast builds


why the name was removed?

lukaszstolarczuk · 2025-05-21T13:39:22Z

.github/workflows/detect_changes.yml

+        run: |
+          echo "Changed files: $ALL_CHANGED_FILES"
+
+  RunReusableDocker:


perhaps simply BuildDocker

lukaszstolarczuk · 2025-05-21T13:40:53Z

.github/workflows/reusable_basic.yml

    strategy:
      matrix:
-        os: ['ubuntu-22.04', 'ubuntu-24.04']
+        ubuntu_ver: ['ubuntu-22.04', 'ubuntu-24.04']


we should probably go back to the os name, as it contains not only the ubu ver

lukaszstolarczuk · 2025-05-21T13:43:54Z

.github/workflows/reusable_basic.yml

-    - name: Install g++-7
-      if: matrix.compiler.cxx == 'g++-7'
-      run: sudo apt-get install -y ${{matrix.compiler.cxx}}
+        echo "${USERPASS}" | sudo -Sk bash -c "


some as above, perhaps sudo su

lukaszstolarczuk · 2025-05-21T13:45:06Z

.github/workflows/reusable_dockers_build.yml

+    runs-on: ubuntu-latest
+    strategy: 
+      matrix:
+        ubuntu-version: [20.04, 22.04, 24.04]


I believe for unity, this should also be os (full name of the distro)

lukaszstolarczuk · 2025-05-21T13:46:53Z

.github/workflows/reusable_fast.yml

    strategy:
      matrix:
        include:
-          - os: windows-latest
+          - ubuntu_ver: ubuntu-22.04


same - re-name to os please

lukaszstolarczuk · 2025-05-21T14:00:45Z

.github/docker/ubuntu-24.04.Dockerfile

+	build-essential \
+	cmake \
+	git \
+	gnupg"


then it should be moved to oneapi installation step

(applies to both docker files)

lukaszstolarczuk · 2025-05-21T14:02:01Z

.github/workflows/reusable_basic.yml

-        ${{ matrix.install_tbb == 'ON' && matrix.disable_hwloc != 'ON' && matrix.shared_library == 'ON' && '--proxy' || '' }}
-        --umf-version ${{env.UMF_VERSION}}
-        ${{ matrix.shared_library == 'ON' && '--shared-library' || '' }}
+    # - name: Test UMF installation and uninstallation


and I believe it's the time to uncomment this - what's failing with that? please send me a link and we'll investigate...

rbanka1 added 2 commits May 5, 2025 15:58

add dockers

b668842

fix

c2d35fc

KFilipek requested changes May 8, 2025

View reviewed changes

rbanka1 added 2 commits May 8, 2025 11:22

test

ef8733e

Merge branch 'main' into newDocker

fd055d3

lukaszstolarczuk mentioned this pull request May 8, 2025

Docker workflow #1105

Closed

10 tasks

rbanka1 added 5 commits May 13, 2025 09:51

separated detect changes - test

5bc7506

Merge branch 'newDocker' of https://github.com/rbanka1/unified-memory…

4b44fe4

…-framework into newDocker

Merge branch 'main' into newDocker

b442229

separated detect changes - test

e14f45e

Merge branch 'newDocker' of https://github.com/rbanka1/unified-memory…

ae65dbf

…-framework into newDocker

rbanka1 force-pushed the newDocker branch 2 times, most recently from 6039c67 to b1d2ec2 Compare May 13, 2025 11:58

lukaszstolarczuk reviewed May 14, 2025

View reviewed changes

rbanka1 changed the title ~~New docker UMF~~ Add dockers to Fast and Basic Builds May 15, 2025

rbanka1 force-pushed the newDocker branch 5 times, most recently from 3552ecc to aefd38a Compare May 20, 2025 10:43

lukaszstolarczuk requested changes May 21, 2025

View reviewed changes

rbanka1 force-pushed the newDocker branch from e519bfe to 8eb78eb Compare May 21, 2025 17:21

.

cc2dfa9

rbanka1 force-pushed the newDocker branch from 7a24ee1 to cc2dfa9 Compare May 21, 2025 17:54

rbanka1 added 3 commits May 21, 2025 19:59

.

783f058

.

70f8231

.

e9e84b1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dockers to Fast and Basic Builds #1298

Add dockers to Fast and Basic Builds #1298

rbanka1 commented May 6, 2025 •

edited

Loading

KFilipek commented May 7, 2025 •

edited

Loading

KFilipek May 7, 2025

lukaszstolarczuk May 8, 2025

rbanka1 May 16, 2025

KFilipek May 7, 2025

lukaszstolarczuk May 8, 2025

rbanka1 May 16, 2025

KFilipek May 7, 2025

rbanka1 May 16, 2025

lukaszstolarczuk May 14, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 14, 2025

rbanka1 May 16, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 21, 2025

lukaszstolarczuk May 21, 2025

		@@ -1,10 +1,10 @@
		# Copyright (C) 2024 Intel Corporation
		# Copyright (C) 2024-2025 Intel Corporation

Add dockers to Fast and Basic Builds #1298

Are you sure you want to change the base?

Add dockers to Fast and Basic Builds #1298

Conversation

rbanka1 commented May 6, 2025 • edited Loading

KFilipek commented May 7, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rbanka1 commented May 6, 2025 •

edited

Loading

KFilipek commented May 7, 2025 •

edited

Loading