-
Notifications
You must be signed in to change notification settings - Fork 35
RST scan #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RST scan #1035
Conversation
docs/config/exclude_words.txt
Outdated
customizable | ||
deallocations | ||
malloc | ||
jemalloc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be an occasion to clean up our docs a little and choose always use e.g. "Jemalloc" (starting with cap) vs "jemalloc" or "UMF" vs "umf" - what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for jemalloc
(this is their original spelling in multiple places)
as for umf
- I think it's showing up here, because we use e.g. include <umf/..
; but normally I agree we should use UMF
in the docs (as it's an abbreviation and should be uppercase)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jemalloc removed, only jemalloc stayed
docs/config/exclude_words.txt
Outdated
customizable | ||
deallocations | ||
malloc | ||
jemalloc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for jemalloc
(this is their original spelling in multiple places)
as for umf
- I think it's showing up here, because we use e.g. include <umf/..
; but normally I agree we should use UMF
in the docs (as it's an abbreviation and should be uppercase)
2d093e3
to
6cee0a1
Compare
6cee0a1
to
dfbcc66
Compare
dfbcc66
to
86416ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor issues, in general it looks good
7c6dacc
to
a9d3d70
Compare
b2b3ad8
to
63eef2a
Compare
63eef2a
to
6901900
Compare
6901900
to
f72a613
Compare
Description
Add scan for RST files in case of some typos and spelling errors alongside with a list of words to exclude.
Checklist
Fixes: #312
Fixes: #148