Support mma.sync.aligned.m16n8k16.row.col.f16.f16.f16.f16 #2943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support mma.sync.aligned.m16n8k16.row.col.f16.f16.f16.f16
more enhancement
jiejanezhang
changed the title
zhiweij1
reviewed
Jul 31, 2025
Comment on lines
2727
to
2735
| // for (int j = 0; j < 4; j++) { | ||
| // *d[0] += | ||
| // static_cast<CDType>(ra[j]) * static_cast<CDType>(rb[j]); | ||
| // *d[1] += static_cast<CDType>(ra[j]) * | ||
| // static_cast<CDType>(rb[j + 4]); | ||
| // *d[2] += static_cast<CDType>(ra[j + 4]) * | ||
| // static_cast<CDType>(rb[j]); | ||
| // *d[3] += static_cast<CDType>(ra[j + 4]) * | ||
| // static_cast<CDType>(rb[j + 4]); |
There was a problem hiding this comment.
Can we remove those line?
zhiweij1
reviewed
Jul 31, 2025
Comment on lines
2722
to
2726
| // fragments and adds it to the corresponding D matrix fragment d0 | ||
| // += row0{ a0, a1, a2, a3 } * col0{ b0, b1, b2, b3 } d1 += row0{ | ||
| // a0, a1, a2, a3 } * col1{ b0, b1, b2, b3 } d2 += row1{ a0, a1, | ||
| // a2, a3 } * col0{ b0, b1, b2, b3 } d3 += row1{ a0, a1, a2, a3 } * | ||
| // col1{ b0, b1, b2, b3 } |
There was a problem hiding this comment.
Can we format those lines? like line 2662
Minor fixings.
Fix LIT test and refine the comments
zhiweij1
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mma.sync.aligned.m16n8k16.row.col.f16.f16.f16.f16.
LIT test and E2E test (SYCLomatic-test:#935) can pass.