Added launch_config objects to pass kernel properties #2885
+60
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejaX-Alaghari
force-pushed
the
kernel_props
branch
2 times, most recently
from
e651be2 to
51b410c
Compare
TejaX-Alaghari
force-pushed
the
kernel_props
branch
from
51b410c to
6ab7370
Compare
ziranzha
reviewed
Jul 7, 2025
| // CHECK-NEXT: dpct::get_out_of_order_queue().parallel_for( | ||
| // CHECK-NEXT: sycl::nd_range<3>(sycl::range<3>(1, 1, 2) * sycl::range<3>(1, 1, 2), sycl::range<3>(1, 1, 2)), | ||
| // CHECK-NEXT: exp_props, [=](sycl::nd_item<3> item_ct1) { | ||
| // CHECK-NEXT: sycl::ext::oneapi::experimental::nd_launch( |
There was a problem hiding this comment.
Why use nd_launch here instead of parallel_for(launch_config...)?
By the way, if we use nd_launch, we should not use KernelPrinter; use CallExprPrinter instead.
There was a problem hiding this comment.
parallel_for(launch_config...) is used when the work-item range is specified using sycl::range object
When sycl::nd_range object is used nd_range(launch_config...) to be used (ref)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
launch_configobjects to pass compile-time kernel properties during kernel launch (sycl_ext_oneapi_enqueue_functions).This behavior replaces the existing deprecated behavior of passing the properties as an argument directly during kernel submission (queue.hpp).