[SYCLomatic] Add explicit cast if CUDA enum type is migrated scoped type and the value is compared to a different type value. #2829
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
zhimingwang36
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new migration rule to handle explicit cast insertion for CUDA enum type comparisons and registers it in the AST traversal. The key changes include:
- Introducing BinaryOperatorCallRule in the header and implementation files.
- Inserting explicit cast replacements for certain enum values.
- Registering the new rule in the AST traversal.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| clang/lib/DPCT/RulesLang/RulesLang.h | Added declaration for BinaryOperatorCallRule. |
| clang/lib/DPCT/RulesLang/RulesLang.cpp | Implemented BinaryOperatorCallRule with cast logic. |
| clang/lib/DPCT/ASTTraversal.cpp | Registered BinaryOperatorCallRule. |
Files not reviewed (1)
- clang/test/dpct/enum_type.cu: Language not supported
zhiweij1
reviewed
May 16, 2025
zhiweij1
approved these changes
May 19, 2025
ziranzha
approved these changes
May 20, 2025
ziranzha
approved these changes
May 20, 2025
Signed-off-by: Chen, Sheng S <sheng.s.chen@intel.com>
zhimingwang36
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.