-
Notifications
You must be signed in to change notification settings - Fork 97
[SYCLomatic] Fix migration bug of __attribute__(__noinline__).
#2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhimingwang36
merged 6 commits into
oneapi-src:SYCLomatic
from
tangjj11:nest-attr-noinline
Oct 24, 2024
Merged
[SYCLomatic] Fix migration bug of __attribute__(__noinline__).
#2387
zhimingwang36
merged 6 commits into
oneapi-src:SYCLomatic
from
tangjj11:nest-attr-noinline
Oct 24, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihanwg
reviewed
Oct 8, 2024
AndyCHHuang
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Tang, Jiajun jiajun.tang@intel.com
e02f4cc to
0f33e80
Compare
yihanwg
approved these changes
Oct 9, 2024
zhimingwang36
approved these changes
Oct 14, 2024
ziranzha
approved these changes
Oct 16, 2024
zhimingwang36
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tang, Jiajun jiajun.tang@intel.com