-
Notifications
You must be signed in to change notification settings - Fork 629
Restore legacy variables #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore legacy variables #1246
Conversation
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* This works with moveit humble Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamoll @Ryanf55 @MarqRazz Any build system compiling a package looks for a dependency in the packages config.cmake.in. Because of the changes made to OMPL CMakeLists to modernize the package management, the look up in other packages should be like ompl::ompl. Since, older versions use ompl to look up, this broke the legacy systems. The above commit enables both the look ups to point to the right libraries. this way both the legacy systems and the new modern approach both work. I have tested the build and plan, both in humble and also jazzy versions of moveit. I believe this solves the issue we are trying to solve. Could anyone help verify this changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works with both MoveIt2 methods, main
and my PR 🎉.
Do we want to add any deprecation information here about the old method? Any notes you want to add to the ReleaseNotes?
@MarqRazz Thank you for verifying the changes. This pull request gives access to deprecated methods. (find_package(ompl)). |
Rebased version of #1185.
Manually resolved a merge conflict.
See #1185 for details