Skip to content

Restore legacy variables #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 24, 2025
Merged

Restore legacy variables #1246

merged 5 commits into from
Mar 24, 2025

Conversation

mamoll
Copy link
Member

@mamoll mamoll commented Mar 19, 2025

Rebased version of #1185.
Manually resolved a merge conflict.
See #1185 for details

Ryanf55 and others added 4 commits March 19, 2025 09:20
Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
* This works with moveit humble

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@mamoll mamoll requested a review from saahu27 March 19, 2025 16:15
Copy link
Contributor

@saahu27 saahu27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ryanf55 @mamoll I can confirm, The changes do not break the existing build. But as these changes are made to support legacy users, i am trying to understand how to verify these changes for legacy users. Please advice. Thank you.

@saahu27
Copy link
Contributor

saahu27 commented Mar 21, 2025

@mamoll @Ryanf55 @MarqRazz Any build system compiling a package looks for a dependency in the packages config.cmake.in. Because of the changes made to OMPL CMakeLists to modernize the package management, the look up in other packages should be like ompl::ompl. Since, older versions use ompl to look up, this broke the legacy systems.

The above commit enables both the look ups to point to the right libraries. this way both the legacy systems and the new modern approach both work.

I have tested the build and plan, both in humble and also jazzy versions of moveit. I believe this solves the issue we are trying to solve.

Could anyone help verify this changes?

Copy link
Contributor

@MarqRazz MarqRazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works with both MoveIt2 methods, main and my PR 🎉.

Do we want to add any deprecation information here about the old method? Any notes you want to add to the ReleaseNotes?

@saahu27
Copy link
Contributor

saahu27 commented Mar 24, 2025

@MarqRazz Thank you for verifying the changes.

This pull request gives access to deprecated methods. (find_package(ompl)).
I am working on the release, which include updates to website, release notes. i will make a mention of this in the release notes.

@mamoll mamoll merged commit 67df28d into main Mar 24, 2025
8 checks passed
@saahu27 saahu27 deleted the restore-legacy-variables-rebase branch March 28, 2025 20:57
@saahu27 saahu27 mentioned this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants