-
-
Notifications
You must be signed in to change notification settings - Fork 54
Support pickleability of classes with callable args #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pickleability of classes with callable args #728
Conversation
…e to functools.partial to support pickleability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good! Just do a small fix in the changelog.
Co-authored-by: Mauricio Villegas <5780272+mauvilsa@users.noreply.github.com>
@mauvilsa Thank you! I updated the changelog. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 6859 6857 -2
=========================================
- Hits 6859 6857 -2 ☔ View full report in Codecov by Sentry. |
What does this PR do?
adapt_class_type
: Replaced the locally definedpartial_instance
wrapper function with afunctools.partial
call to construct class instantiators, ensuring they are compatible with pickle and other serialization libraries.See discussion in #727 for more context.
Before submitting