Skip to content

Conversation

@mmta41
Copy link

@mmta41 mmta41 commented Mar 14, 2020

Prayer time based on location and TimeZone
Automatic play Azaan audio.

@omid
Copy link
Owner

omid commented Mar 14, 2020

It's so cool, thanks.

I have some general suggestions, since all people are not Muslims, please change the naming of files and also options in the settings to something like "Islamic prayer timing" or even more accurate "Shia Prayer Timing".

And exactly because of the same reason, I would suggest disabling it by default. Because in the future we cannot enable all kind of prayer times at the same time.

@mmta41
Copy link
Author

mmta41 commented Mar 15, 2020

Hi,
I'm totally agree.
There are many options require including:

  • select calculation method ( it is now based on University of Tehran )
  • more customization for Sunni brothers such as:
    1. two more call for pray(Azaan)
    2. more option for Azaan sound and also choosing from local files
  • show notification with stop button (I don't know how create one yet)
    and decent decoration, this is my first code in gnome-extension
    I just like to contribute this great project

Copy link
Owner

@omid omid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I agree we can improve most of the issued I've mentioned later.
By the way, I put 2-3 comments. It would be awesome if you could take care of them.

MainLoop.source_remove(this._prayerTimeout);
this._prayerTimeout = null;
}
this._prayerTimeout = MainLoop.timeout_add(60000 - (new Date().getSeconds() * 1000), Lang.bind(this,this._prayerTimeLoop));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this in the "disable" function.
And I would suggest adding it to the "enable" function.

Another suggestion is to ignore adding timeout when the feature is disabled.

}));
item = new Gtk.CheckButton({label: _('Show Pray Time')});
this.vbox2.add(item);
Schema.bind('praytime-visible', item, 'active', Gio.SettingsBindFlags.DEFAULT);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please disable this and Azaan options, by default.

<description>Display official international events.</description>
</key>
<key name="praytime-visible" type="b">
<default>true</default>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.
Please disable this and Azaan options, by default.

add Prayer song
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants