Support nested attributes introduced in PHP 8.1 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olvlvl
force-pushed
the
main-use-serialization
branch
from
a925621 to
119f17b
Compare
olvlvl
force-pushed
the
main-use-serialization
branch
from
119f17b to
f4b1965
Compare
olvlvl
force-pushed
the
main-use-serialization
branch
from
f4b1965 to
d3ffab5
Compare
Pull Request Test Coverage Report for Build 15706106380Details
💛 - Coveralls |
olvlvl
force-pushed
the
main-use-serialization
branch
from
d3ffab5 to
1333cc8
Compare
olvlvl
force-pushed
the
main-use-serialization
branch
2 times, most recently
from
1eb9989 to
f879cc4
Compare
olvlvl
force-pushed
the
main-use-serialization
branch
3 times, most recently
from
0d64e37 to
6e954f3
Compare
to support nested attributes
olvlvl
force-pushed
the
main-use-serialization
branch
from
6e954f3 to
d488c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested attributes introduced in PHP 8.1 are not supported at the moment. Because the attribute arguments are exported with
var_export(), nested attributes need to implement__set_state, otherwise, reading the attributes will result in an error, as reported by #28.Proposed solution
To support nested attributes, attribute arguments should be serialized instead of exported.