Skip to content

wip: add new topological order iter #244

wip: add new topological order iter

wip: add new topological order iter #244

Triggered via push September 15, 2025 06:11
Status Failure
Total duration 4m 25s
Artifacts
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 5 warnings
use of `println!`: crates/chain/src/canonical_iter.rs#L347
error: use of `println!` --> crates/chain/src/canonical_iter.rs:347:17 | 347 | println!("txid: {:?}", txid); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_stdout
variables can be used directly in the `format!` string: crates/chain/src/canonical_iter.rs#L347
error: variables can be used directly in the `format!` string --> crates/chain/src/canonical_iter.rs:347:17 | 347 | println!("txid: {:?}", txid); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args help: change this to | 347 - println!("txid: {:?}", txid); 347 + println!("txid: {txid:?}"); |
use of `println!`: crates/chain/src/canonical_iter.rs#L322
error: use of `println!` --> crates/chain/src/canonical_iter.rs:322:17 | 322 | println!("topological_txs: {:?}", topological_txs); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_stdout = note: requested on the command line with `-D clippy::print-stdout`
variables can be used directly in the `format!` string: crates/chain/src/canonical_iter.rs#L322
error: variables can be used directly in the `format!` string --> crates/chain/src/canonical_iter.rs:322:17 | 322 | println!("topological_txs: {:?}", topological_txs); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-D clippy::uninlined-format-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]` help: change this to | 322 - println!("topological_txs: {:?}", topological_txs); 322 + println!("topological_txs: {topological_txs:?}"); |
this loop never actually loops: crates/chain/src/canonical_iter.rs#L266
error: this loop never actually loops --> crates/chain/src/canonical_iter.rs:266:9 | 266 | / loop { 267 | | while let Some((txid, tx)) = self.unprocessed_assumed_txs.next() { 268 | | if !self.is_canonicalized(txid) { 269 | | self.mark_canonical(txid, tx, CanonicalReason::assumed()); ... | 356 | | return None; 357 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop = note: `#[deny(clippy::never_loop)]` on by default
this `.filter_map(..)` can be written more simply using `.filter(..)`: crates/chain/src/canonical_iter.rs#L237
error: this `.filter_map(..)` can be written more simply using `.filter(..)` --> crates/chain/src/canonical_iter.rs:237:31 | 237 | let roots_queue = staged_queue | _______________________________^ 238 | | .iter() 239 | | .filter_map(|txid| { 240 | | let tx = self.tx_graph.get_tx(*txid).expect("should have tx"); ... | 254 | | }) | |__________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map = note: `-D clippy::unnecessary-filter-map` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unnecessary_filter_map)]`
Code Coverage
Process completed with exit code 1.
Code Coverage
Cache not found for keys: v0-rust-Codecov-Linux-x64-41fd49fb-e8264f82, v0-rust-Codecov-Linux-x64-41fd49fb
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Code Coverage
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/