test: add scenarios for canonical_txs topological order #242

error: use of `println!` --> crates/chain/tests/test_tx_graph.rs:1796:17 | 1796 | / println!( 1797 | | "ancestor: ({:?}, {:?}) , descendant ({:?}, {:?})", 1798 | | txid, pos, this_txid, desc_pos 1799 | | ); | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_stdout = note: requested on the command line with `-D clippy::print-stdout`

variables can be used directly in the `format!` string: crates/chain/tests/test_tx_graph.rs#L1796

error: variables can be used directly in the `format!` string --> crates/chain/tests/test_tx_graph.rs:1796:17 | 1796 | / println!( 1797 | | "ancestor: ({:?}, {:?}) , descendant ({:?}, {:?})", 1798 | | txid, pos, this_txid, desc_pos 1799 | | ); | |_________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args = note: `-D clippy::uninlined-format-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::uninlined_format_args)]`

unneeded `return` statement: crates/chain/tests/test_tx_graph.rs#L1804

error: unneeded `return` statement --> crates/chain/tests/test_tx_graph.rs:1804:5 | 1804 | return true; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `-D clippy::needless-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_return)]` help: remove `return` | 1804 - return true; 1804 + true |

you are using an explicit closure for copying elements: crates/chain/tests/test_tx_graph.rs#L1764

error: you are using an explicit closure for copying elements --> crates/chain/tests/test_tx_graph.rs:1764:29 | 1764 | let canonical_txs = canonical_txs.iter().map(|txid| *txid).collect::<Vec<_>>(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `canonical_txs.iter().copied()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `-D clippy::map-clone` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::map_clone)]`

you seem to use `.enumerate()` and immediately discard the index: crates/chain/tests/test_tx_graph.rs#L1743

error: you seem to use `.enumerate()` and immediately discard the index --> crates/chain/tests/test_tx_graph.rs:1743:26 | 1743 | for (_, scenario) in scenarios.iter().enumerate() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index = note: `-D clippy::unused-enumerate-index` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::unused_enumerate_index)]` help: remove the `.enumerate()` call | 1743 - for (_, scenario) in scenarios.iter().enumerate() { 1743 + for scenario in scenarios.iter() { |

Rust clippy

Clippy had exited with the 101 exit code

Build & Test (1.88.0, true, --no-default-features --features miniscript/no-std,bdk_chain/hashbrown)

Process completed with exit code 101.

Build & Test (1.75.0, --all-features)

The operation was canceled.

Build & Test (1.75.0, --all-features)

The strategy configuration was canceled because "build-test._1_88_0_true_--no-default" failed

Build & Test (1.75.0, --no-default-features --features miniscript/no-std,bdk_chain/hashbrown)

The operation was canceled.

Build & Test (1.75.0, --no-default-features --features miniscript/no-std,bdk_chain/hashbrown)

The strategy configuration was canceled because "build-test._1_88_0_true_--no-default" failed