Skip to content

Conversation

@Imran-imtiaz48
Copy link

Improvements

  1. Comments: o Added inline comments for each column to explain its purpose. o Provided comments on constraints and index options for clarity.
  2. Readability: o Improved formatting by aligning columns and properties for better readability. o Used consistent indentation and spacing.
  3. Description: o Provided clear descriptions for the script’s purpose and behavior.

Improvements
1.	Comments:
o	Added inline comments for each column to explain its purpose.
o	Provided comments on constraints and index options for clarity.
2.	Readability:
o	Improved formatting by aligning columns and properties for better readability.
o	Used consistent indentation and spacing.
3.	Description:
o	Provided clear descriptions for the script’s purpose and behavior.
@olahallengren
Copy link
Owner

@Imran-imtiaz48, thank you for your work on this.

This is a good idea. However, it doesn't work with the way I am currently building and releasing the code. I am using SMO to script out the objects from a SQL Server instance.

I will look into how I can improve this.

@daiplusplus
Copy link

daiplusplus commented Aug 19, 2025

@olahallengren it doesn't work with the way I am currently building and releasing the code. I am using SMO to script out the objects from a SQL Server instance.

Should I take this to mean you aren't currently accepting any PRs from the community until further notice? If this is the case can you please update your repo's README just so everyone's expectations are adjusted? I was about to submit a PR myself (just a quick bugfix for a typo'd parameter on Line 943 in IndexOptimize.sql) but I only saw your message here by-chance just now - so I narrowly avoided wasting your - and my - time, erk 😬

@olahallengren
Copy link
Owner

@daiplusplus, my comment was specific to changing formatting and adding comments to table definitions.

I’ve made many updates to the scripts based on community issues and pull requests. However, I usually include these changes in an upcoming release rather than merging pull requests directly. Please go ahead and create a pull request, and I’ll review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants