feat: migrate to simple-git #40

jcha0713 · 2025-07-12T00:37:06Z

This PR replaces direct git utilities with simple-git wrappers.

use simple-git wrapper for branch/project metadata extraction
add unit tests to check returning error types

This resolves #35.

gemini-code-assist

Summary of Changes

Hello @jcha0713, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors how the application interacts with Git. By migrating to the simple-git library and introducing a dedicated Git service, the codebase becomes more modular, testable, and resilient to Git-related errors. This change improves the overall stability and maintainability of the application's Git integration.

Highlights

Refactoring Git Interactions: Replaced direct git utility calls with the simple-git library for more robust and maintainable Git operations, centralizing all Git-related logic.
Improved Error Handling: Introduced custom error classes (GitError, EmptyCommitMessageError, IsNotGitRepositoryError) for better clarity and structured handling of Git-related issues.
Comprehensive Unit Testing: Added a new test suite using Vitest to thoroughly test the GitService methods, covering various scenarios including successful operations and specific error conditions.
Asynchronous Operations: Updated relevant parts of the codebase (cli.ts, branch.ts, project.ts, QueryContext.tsx) to handle the new asynchronous nature of Git operations, ensuring proper flow control.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This PR migrates git interactions to simple-git, introducing a GitService and unit tests. The review focuses on improving robustness, maintainability, and performance, including ensuring distinct error names, improving project identifiers, reducing code duplication, and adopting a singleton pattern for GitService.

gemini-code-assist · 2025-07-12T00:39:15Z

src/core/utils/branch.ts

-export function ensureBranch(projectId: string) {
-  const branchMeta = getBranchMetadata(projectId);
+export async function ensureBranch(projectId: string) {
+  const { getBranchMetadata } = createGitService();


Calling createGitService() here creates a new instance each time, re-initializing the service and its internal cache. Use a singleton pattern to ensure a single instance of the git service is reused across the application for performance and consistency.

gemini-code-assist · 2025-07-12T00:39:15Z

src/core/utils/project.ts

-export function ensureProject() {
-  const projectMeta = getProjectMetadata();
+export async function ensureProject() {
+  const { getProjectMetadata } = createGitService();


Calling createGitService() here creates a new instance. Since this function is also called in ensureBranch, this leads to multiple instances of the service being created. Use a singleton pattern to ensure a single instance of the git service is reused across the application for performance and consistency.

gemini-code-assist · 2025-07-12T00:39:15Z

src/core/git/errors.ts

+  constructor(message: string) {
+    super(message);
+  }


For improved error identification, define the name property for EmptyCommitMessageError. This ensures the error type is correctly identified in logs and error handling.

constructor(message: string) { super(message); this.name = "EmptyCommitMessageError"; }

gemini-code-assist · 2025-07-12T00:39:15Z

src/core/git/errors.ts

+export class IsNotGitRepositoryError extends GitError {
+  constructor(message: string) {
+    super(message);


Define the name property for IsNotGitRepositoryError to ensure correct error type identification during debugging and error handling.

Suggested change

export class IsNotGitRepositoryError extends GitError {

constructor(message: string) {

super(message);

constructor(message: string) {

super(message);

this.name = "IsNotGitRepositoryError";

}

src/core/git/gitManager.test.ts

gemini-code-assist · 2025-07-12T00:39:16Z

src/core/git/gitManager.ts

+    const isGitRepo = await checkIsRepo();
+    if (!isGitRepo) {
+      throw new IsNotGitRepositoryError(
+        "Current directory is not a git repository",
+      );
+    }


The git repository check is duplicated across getProjectMetadata, getBranchMetadata, and commit. Refactor this into a private helper function within createGitService to reduce redundancy and improve maintainability.

gemini-code-assist · 2025-07-12T00:39:16Z

src/core/git/gitManager.ts

+      const repoName = path.basename(repoPath);
+
+      return {
+        id: repoPath, // TODO: make it unique


Using repoPath as the project id is not robust as it changes if the repository is moved. Use a more stable unique identifier, such as the hash of the initial commit (git rev-list --max-parents=0 HEAD).

gemini-code-assist · 2025-07-12T00:39:16Z

src/core/git/gitManager.ts

+      const currentBranchFull = await git.raw("symbolic-ref", "HEAD");
+      const currentBranchShort = await git.raw(
+        "symbolic-ref",
+        "HEAD",
+        "--short",
+      );


The branchSummary object from git.branchLocal() contains the current branch's short name in branchSummary.current. Use this directly instead of calling git.raw for efficiency.

const currentBranchFull = await git.raw("symbolic-ref", "HEAD"); const currentBranchShort = branchSummary.current;

jcha0713 added 3 commits July 11, 2025 18:41

feat: add Git service with commit functionality and validation

acc6233

feat: rewrite git metadata extraction operations using simple-git

8882f8c

refactor: use createGitService to extract metadata

124b2cf

gemini-code-assist bot reviewed Jul 12, 2025

View reviewed changes

jcha0713 added 2 commits July 12, 2025 09:46

fix: use correct function to test IsNotGitRepositoryError

8be9ed9

fix: use global cache for git instances

fcdac17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: migrate to simple-git #40

feat: migrate to simple-git #40

jcha0713 commented Jul 12, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 12, 2025

Uh oh!

gemini-code-assist bot Jul 12, 2025

Uh oh!

gemini-code-assist bot Jul 12, 2025

Uh oh!

gemini-code-assist bot Jul 12, 2025

Uh oh!

Uh oh!

gemini-code-assist bot Jul 12, 2025

Uh oh!

gemini-code-assist bot Jul 12, 2025

Uh oh!

gemini-code-assist bot Jul 12, 2025

Uh oh!

Uh oh!

feat: migrate to simple-git #40

Are you sure you want to change the base?

feat: migrate to simple-git #40

Conversation

jcha0713 commented Jul 12, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!