All code is now in english #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… insuranceRate, loanDuration, fictitiousLoanRate, commisionFees, PropertyTax, housingTax, containers are all in english; Rent becomes general income; Light mode header now also has background color;
- Updated box-shadow property in styles.css for a more refined visual effect. - Renamed CSS class from .input-container to .income-container for clarity. - Removed outdated English and French translation files (en.json, fr.json). - Updated formHandlerMethods tests to reflect function name changes and improved variable naming for clarity. - Adjusted HTML element selectors in tests to match updated IDs in the form. - Updated translation keys in en.json and fr.json for consistency and clarity, including changes to agency commission, loan duration, and report titles.
- Removed direct event listener assignments from form-handler.js and moved them to a new event-listeners.js file for better separation of concerns. - Updated addIncome function to accept a document parameter for improved testability. - Enhanced calculateAPR and related functions to include file fees in calculations. - Added tests for addIncome function to ensure correct behavior with valid and invalid inputs. - Implemented browser language detection in handle-language.js to set default language based on user preferences. - Updated translations in en.json and fr.json to include new keys for file fees. - Added new event listeners for form inputs to trigger APR calculations on input changes.
merge main
…slation handling in JavaScript, and adjusted icon links in posters.
…t CSS styling for dark mode; Repaired document generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
langis now also in english