-
Notifications
You must be signed in to change notification settings - Fork 194
[wasm] Option to implement OCaml strings with JavaScript strings #1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7622533
to
1e6911d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.
2185d26
to
759358a
Compare
54f91c2
to
dd3f973
Compare
cae36fc
to
7494238
Compare
6d4097d
to
787eed2
Compare
This reverts commit a0133d0.
787eed2
to
eb9aa27
Compare
compiler/lib-wasm/runtime.ml
Outdated
not | ||
(String.equal module_ "" | ||
|| List.mem ~eq:String.equal module_ allowed_imports)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not | |
(String.equal module_ "" | |
|| List.mem ~eq:String.equal module_ allowed_imports)) | |
not (List.mem ~eq:String.equal module_ allowed_imports)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn’t it be:
not | |
(String.equal module_ "" | |
|| List.mem ~eq:String.equal module_ allowed_imports)) | |
not | |
(String.equal module_ "str" | |
|| List.mem ~eq:String.equal module_ allowed_imports)) |
But even then I’m getting errors…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should update the list of allowed imports in compile.ml
instead.
Uh oh!
There was an error while loading. Please reload this page.