Modernize stdlib #1764
Merged
Modernize stdlib #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorimoto
approved these changes
Dec 10, 2024
|
@TyOverby, any opinion ? |
|
I think we may have moved away from stdlib_modern for performance reasons; I can check when I get back to work in January |
There was a problem hiding this comment.
Copilot reviewed 3 out of 7 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- compiler/lib-runtime-files/tests/all.ml: Language not supported
- compiler/tests-compiler/gh1051.ml: Language not supported
- compiler/tests-compiler/util/util.ml: Language not supported
- compiler/tests-compiler/util/util.mli: Language not supported
|
Looks like we're using |
TyOverby
approved these changes
Dec 30, 2024
smorimoto
force-pushed
the
modern-stdlib
branch
from
883f3e6 to
2aae97e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove
modern_stdlib.js