feat(task): add index on job_job, let job query data range configurable #4440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ult value -1
What type of PR is this?
type-feature
What this PR does / why we need it:
in previous code implementation, job will only process create_time in recent 30 days. that may lead to some job run over 30 days not handled
make this value configurable and assign default value with -1 means process all suitable jobs.
use status, executor_destroyed_time, create_time to query job_job table may leads to full table scan.
add index (status, executor_destroyed_time) on job_job to accelerate this query.
The following is time cost for 500 thousands records in job_job with SQL select count(1) from job_job where executor_destroyed_time is null and status in ('DONE', 'FAILED', 'CANCELED')
without index cost 1.1s
with index cost 0.1s
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: