Skip to content

fix enable & disable syntax errors #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: hbase_compat_3_2.0
Choose a base branch
from

Conversation

Zhou-jw
Copy link
Contributor

@Zhou-jw Zhou-jw commented May 30, 2025

Summary

  1. Fix syntax errors
  2. Align obkv-hbase enable/disable exception handling with HBase

Solution Description

@maochongxin
Copy link
Contributor

git rebase -i HEAD~6

ObTableMetaRequest request = new ObTableMetaRequest();
request.setMetaType(getMetaType());
Map<String, Object> requestData = new HashMap<>();
requestData.put("table_name", tableName);
String jsonData = JSON.toJSONString(requestData);
request.setData(jsonData);
execute(tableClient, request);
try{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

漏了空格

ObTableMetaRequest request = new ObTableMetaRequest();
request.setMetaType(getMetaType());
Map<String, Object> requestData = new HashMap<>();
requestData.put("table_name", tableName);
String jsonData = JSON.toJSONString(requestData);
request.setData(jsonData);
execute(tableClient, request);
try{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

漏了空格

ObTableException obEx = (ObTableException) cause;
int errCode = obEx.getErrorCode();
if(ResultCodes.OB_KV_TABLE_NOT_DISABLED.errorCode == errCode) {
throw new TableNotEnabledException("Table is not enabled: " + tableName + obEx);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

异常描述有误

@Zhou-jw Zhou-jw force-pushed the hbase_compat_3_2.0_enable_disable branch 2 times, most recently from f234813 to da5089c Compare June 6, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants