Fix(cli): bugs in cli first round testing #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the same path for each tenant, will raise an NFS error "Error 9081 (HY000): format file does not match, try to set a new directory". This commit fixes the issue by ensuring the destination configuration correctly matches the current cluster/tenant/backup type.
powerfooI
reviewed
Dec 13, 2024
| if !utils.CheckIfClusterExists(cmd.Context(), clusterOptions.Name, clusterOptions.Namespace) { | ||
| break | ||
| } | ||
| logger.Printf("Cluster %s already exists in namespace %s, please input another cluster name", clusterOptions.Name, clusterOptions.Namespace) |
There was a problem hiding this comment.
This for-loop seems to be endless if the flow gets here.
There was a problem hiding this comment.
Yes, because here we want to check if the cluster name typed by user is available in the corresponding namespace, and if it is not exists (which is meet the requirements, the return value of utils.CheckIfClusterExists is false), and the workflow will be advanced.
There was a problem hiding this comment.
OK, I see. The cli tool is asking the user to enter the name and namespace of the cluster here.
| if !utils.CheckIfTenantExists(cmd.Context(), tenantOptions.Name, clusterOptions.Namespace) { | ||
| break | ||
| } | ||
| logger.Printf("Tenant %s already exists in namespace %s, please input another tenant name", tenantOptions.Name, clusterOptions.Namespace) |
powerfooI
approved these changes
Dec 13, 2024
| if !utils.CheckIfClusterExists(cmd.Context(), clusterOptions.Name, clusterOptions.Namespace) { | ||
| break | ||
| } | ||
| logger.Printf("Cluster %s already exists in namespace %s, please input another cluster name", clusterOptions.Name, clusterOptions.Namespace) |
There was a problem hiding this comment.
OK, I see. The cli tool is asking the user to enter the name and namespace of the cluster here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fix bugs in the first round of cli testing. The problem solved is as follows:
showcmd: 426a61fCompletefunction when creating a backup policy: 81a827d, and the details can be seen in the commit message. The tenant’s create command has also been modified in 4faa655Solution Description