Skip to content

Conversation

@lizzy-0323
Copy link
Contributor

@lizzy-0323 lizzy-0323 commented Nov 20, 2024

Summary

  1. Update validate rules in resource name and tenant name to stricter rules, also add test in validator_test.go: e69a85d
  2. Fix bug in cluster creation and set the default cluster mode to service : 6363630 and c01070d
  3. Add completion in tenant creation and fix bug in Validate function: 30341d3
  4. Update format in show cmd and demo cmd: 673de27 and 9e7b094

Solution Description

}

// AddUnitFlags add unit-resource-related flags
func (o *UpdateOptions) AddUnitFlags(cmd *cobra.Command) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this function deleted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous commit was incomplete and is now committed. In the update command of tenant, i want to provide the user with fewer flags for a clearer description.

Copy link
Collaborator

@powerfooI powerfooI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@powerfooI powerfooI merged commit 8ddc6ad into oceanbase:master Nov 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants