-
Notifications
You must be signed in to change notification settings - Fork 44
Remove pinned OpenSSL packages from Cygwin setup step #948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cfdc9f9
to
c80c9c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This pull request updates the OpenSSL version used in the Cygwin setup for OCaml.
- Updated "mingw64-i686-openssl" from version 1.1.1w-0.1 to 3.0.16-1.
- Updated "mingw64-x86_64-openssl" from version 1.1.1w-0.1 to 3.0.16-1.
Reviewed Changes
File | Description |
---|---|
packages/setup-ocaml/src/windows.ts | Updated OpenSSL package versions for Windows setup. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
@MisterDA You might want to try this branch 😉 |
Why is the |
Is it even necessary to always install this package? |
That was actually what I tried, but the new version was not installed: cfdc9f9
|
f46c95b
to
3339a21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR removes the pinned OpenSSL package versions from the Cygwin setup step to align with the stable release of version 3.0.16-1.
- Removed pinned versions for mingw64-i686-openssl and mingw64-x86_64-openssl.
Reviewed Changes
File | Description |
---|---|
packages/setup-ocaml/src/windows.ts | Removed OpenSSL package pins from the Cygwin setup script. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Either the Cygwin cache key needs to be changed (to invalidate Cygwin caches containing the old package) or Incidentally, rather than scraping cygwin.com for the DLL version (3.5.7), might it be better to parse the table in https://www.cygwin.com/packages/summary/cygwin.html ? |
I think it makes sense to upgrade every time. Retrieving the DLL version from the table sounds like a fine idea, but I'm worried about which value to retrieve and how frequently it's changed too often. |
Signed-off-by: Sora Morimoto <sora@morimoto.io>
3339a21
to
4d36e4d
Compare
That value should change at exactly the same rate as the front page (in theory), because the front page is also supposed to display it! |
3.0.16-1
has finally been marked as stable and released, so maybe we can just drop them?https://cygwin.com/packages/summary/mingw64-x86_64-openssl-src.html