Skip to content

Remove pinned OpenSSL packages from Cygwin setup step #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Mar 10, 2025

3.0.16-1 has finally been marked as stable and released, so maybe we can just drop them?
https://cygwin.com/packages/summary/mingw64-x86_64-openssl-src.html

@smorimoto smorimoto force-pushed the unpin-mingw64-openssl branch from cfdc9f9 to c80c9c8 Compare March 10, 2025 23:11
@smorimoto smorimoto changed the title Remove version constraints for OpenSSL packages in Cygwin setup Update OpenSSL version in Cygwin setup to 3.0.16 Mar 10, 2025
@smorimoto smorimoto requested review from Copilot and dra27 March 10, 2025 23:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request updates the OpenSSL version used in the Cygwin setup for OCaml.

  • Updated "mingw64-i686-openssl" from version 1.1.1w-0.1 to 3.0.16-1.
  • Updated "mingw64-x86_64-openssl" from version 1.1.1w-0.1 to 3.0.16-1.

Reviewed Changes

File Description
packages/setup-ocaml/src/windows.ts Updated OpenSSL package versions for Windows setup.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@smorimoto smorimoto added bug Something isn't working enhancement New feature or request upstream and removed enhancement New feature or request labels Mar 10, 2025
@smorimoto smorimoto marked this pull request as ready for review March 10, 2025 23:29
@smorimoto
Copy link
Member Author

@MisterDA You might want to try this branch 😉

@dra27
Copy link
Member

dra27 commented Mar 11, 2025

Why is the =3.0.16-1 necessary?

@MisterDA
Copy link
Contributor

Is it even necessary to always install this package?

@smorimoto
Copy link
Member Author

Why is the =3.0.16-1 necessary?

That was actually what I tried, but the new version was not installed: cfdc9f9
https://github.com/ocaml/setup-ocaml/actions/runs/13776444308/job/38526599501#step:3:50

Is it even necessary to always install this package?

@smorimoto smorimoto marked this pull request as draft March 11, 2025 11:29
@smorimoto smorimoto force-pushed the unpin-mingw64-openssl branch from f46c95b to 3339a21 Compare March 11, 2025 11:36
@smorimoto smorimoto changed the title Update OpenSSL version in Cygwin setup to 3.0.16 Remove pinned OpenSSL packages from Cygwin setup step Mar 11, 2025
@smorimoto smorimoto marked this pull request as ready for review March 11, 2025 11:37
@smorimoto smorimoto requested a review from Copilot March 11, 2025 12:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR removes the pinned OpenSSL package versions from the Cygwin setup step to align with the stable release of version 3.0.16-1.

  • Removed pinned versions for mingw64-i686-openssl and mingw64-x86_64-openssl.

Reviewed Changes

File Description
packages/setup-ocaml/src/windows.ts Removed OpenSSL package pins from the Cygwin setup script.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@dra27
Copy link
Member

dra27 commented Mar 11, 2025

Either the Cygwin cache key needs to be changed (to invalidate Cygwin caches containing the old package) or --upgrade-also needs to be added to the setup invocation. Instinctively I'd invalidate the caches, rather than always running a Cygwin upgrade, but given that the cache key already includes the Cygwin DLL version, maybe always running the upgrade isn't too bad a plan?

Incidentally, rather than scraping cygwin.com for the DLL version (3.5.7), might it be better to parse the table in https://www.cygwin.com/packages/summary/cygwin.html ?

@smorimoto
Copy link
Member Author

I think it makes sense to upgrade every time. Retrieving the DLL version from the table sounds like a fine idea, but I'm worried about which value to retrieve and how frequently it's changed too often.

Signed-off-by: Sora Morimoto <sora@morimoto.io>
@smorimoto smorimoto force-pushed the unpin-mingw64-openssl branch from 3339a21 to 4d36e4d Compare March 12, 2025 00:15
@smorimoto smorimoto merged commit 928a230 into master Mar 12, 2025
18 checks passed
@smorimoto smorimoto deleted the unpin-mingw64-openssl branch March 12, 2025 00:21
@dra27
Copy link
Member

dra27 commented Mar 12, 2025

Retrieving the DLL version from the table sounds like a fine idea, but I'm worried about which value to retrieve and how frequently it's changed too often.

SELECT TOP 1 Version FROM Data WHERE Status = 'stable' ORDER BY SemVer(Version) DESC

That value should change at exactly the same rate as the front page (in theory), because the front page is also supposed to display it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinning OpenSSL to 1.1.1w-0.1 doesn't work with new packages expecting OpenSSL 3 Windows: opam fails to install conf-libcurl.
3 participants