Skip to content

feat: add 'RESTART REQUIRED' to specific settings sections #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Sep 30, 2025
Merged

feat: add 'RESTART REQUIRED' to specific settings sections #3635

merged 20 commits into from
Sep 30, 2025

Conversation

ilandikov
Copy link
Collaborator

Types of changes

Done by pairing with @claremacrae

Changes visible to users:

  • New feature (prefix: feat - non-breaking change which adds functionality)
    • Issue/discussion:
  • Translation (prefix: i18n - additions or improvements to the translations - see Support a new language)
  • Documentation (prefix: docs - improvements to any documentation content for users)

Description

  • Change settings UI to explicitly state which settings require a restart
  • We reused an existing translation string and used ChatGPT and own knowledge to update existing translations

Motivation and Context

  • Save users from reloading vault unnecessarily
  • Make it easier to update remaining settings to auto-reload

How has this been tested?

  • Manual tests in demo vault

Checklist

  • My code follows the code style of this project and passes yarn run lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • My change has adequate Unit Test coverage.
    • Settings UI is not covered by tests

Terms

@ilandikov
feat: ! editing format requires restart
9218fb5
@ilandikov
feat: ! reuse changeRequiresRestart translation
4792ec2 
Note: other languages will need updating
@ilandikov
feat: ! remove red message from the top of the settings
1076f75
@ilandikov
refactor: ! remove unused CSS class
e208d33
@ilandikov
refactor: ! prepare to add second line to description
72489a6
@ilandikov
feat: ! note another setting that requires a restart
4257a95
@ilandikov
feat: ! note status edits require a restart
c356bbd
@ilandikov
feat: ! note another setting that requires a restart
a07d278
@ilandikov
feat: ! note another setting that requires a restart
1a8860c
@ilandikov
refactor: ! prepare to add second line to description
5ab20ff
@ilandikov
feat: ! note another setting that requires a restart
5f4d33f
@ilandikov
feat: ! note another setting that requires a restart
d4bd089
@ilandikov
refactor: ! prepare to add second line to description
0ce61fa
@ilandikov
feat: ! note another two settings that require a restart
82e37b7
@ilandikov
i18n: ! update Russian translation of restart instruction
c61dea6
@ilandikov
docs: soften statement on need to restart
31125b0
@ilandikov
i18n: ! update translation for restart message
3541c89
@ilandikov ilandikov added scope: documentation Improvements or additions to documentation scope: internationalisation Translations - Making the plugin work well for non-English-language users - also known as i18n scope: settings Issues referring to the Tasks Settings panel in Obsidian labels Sep 28, 2025
claremacrae
claremacrae approved these changes Sep 28, 2025
View reviewed changes
Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ilyas,

The comment on the Korean translation is FYI - I will go with your judgment...

My updating of the other settings images is a work-in-progress....

claremacrae and others added 2 commits September 30, 2025 09:20
@claremacrae
docs: Update remaining images to include 'REQUIRES RESTART' line
36289b3
@claremacrae @ilandikov
i18n: Update Korean for 'RESTART REQUIRED'
d587f14 
Co-Authored-By: Ilyas Landikov <93825870+ilandikov@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

claremacrae
claremacrae approved these changes Sep 30, 2025
View reviewed changes
Copy link
Collaborator

@claremacrae claremacrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really happy we did this. It will save new users doing a lot of restarts!

@claremacrae claremacrae merged commit ec274b3 into obsidian-tasks-group:main Sep 30, 2025
3 checks passed
@claremacrae claremacrae changed the title feat: improve settings UI feat: add 'RESTART REQUIRED' to specific settings sections Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claremacrae claremacrae claremacrae approved these changes

Assignees

No one assigned

Labels

scope: documentation Improvements or additions to documentation scope: internationalisation Translations - Making the plugin work well for non-English-language users - also known as i18n scope: settings Issues referring to the Tasks Settings panel in Obsidian

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ilandikov @claremacrae