Skip to content

Fix: wrong insertion position for completion #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Peeeaje
Copy link

@Peeeaje Peeeaje commented Mar 31, 2025

Resolves #28

@neo451
Copy link
Member

neo451 commented Apr 1, 2025

I think apply this fix on markdown style links is not right? is it correct on you end? the wiki link fix seems good to me.

@danilka4
Copy link

danilka4 commented Apr 1, 2025

Tested it out, it appears that creating a new note places a third opening bracket [ into the completion. [[newnote becomes [[[newnote]], for example.

@noamsto
Copy link

noamsto commented May 1, 2025

This worked for me as well.
Why it's not merged?

@neo451
Copy link
Member

neo451 commented May 2, 2025

@noamsto cause this fix had more side effects on me and others' experience, the bracket is just wrong on the other side, I am working on the lsp branch #52 that will fix this and in the meantime I don't know how to fix this properly in the old framework

@noamsto
Copy link

noamsto commented May 2, 2025

@neo451, Thanks
Thought it worked for me but I was wrong.
My PR #99 Handles it I think

@neo451 neo451 closed this May 2, 2025
@neo451
Copy link
Member

neo451 commented May 6, 2025

@all-contributors please add @Peeeaje for code

Copy link

@neo451

I've put up a pull request to add @Peeeaje! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion not inserting a link correctly
4 participants