-
Notifications
You must be signed in to change notification settings - Fork 39
More Configuration for Templates #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
More Configuration for Templates #184
Conversation
I found it helpful to have a shared testing library for creating a temporary client because previously we had multiple implementations for doing so. This current implementation, though minimal, covers the bases for managing creation/teardown.
ok after a while I finally get what the PR is trying to do, pretty cool stuff!! But that is quite a sign that we need to put docs, you can put a new section in the wiki's template page, named Any chance the The following points are not needed to be addressed and just for discussion only. It feels a bit clunky to change the client's config and then restore it. As I discussed in https://github.com/orgs/obsidian-nvim/discussions/140#discussioncomment-13088512 Having a client that don't hold very many state is just not good for both development and user scripting. A simple |
Custom Directories and
note_id_func
s for templatesThis PR implements the features discussed by #165.
In short, it:
note_id_func
for naming themselves speciallyTesting the Behavior
Note
Although some logic is case insensitive, testing on Linux revealed that not all of it is. For this reason,
the case of template specified in the customization ("zettel" in this example") should match the name
and case of the template id
Note
This is a duplicate of #174 because the original forked repository was based on the deprecated epwalsh version, so
I had to delete that fork, and recreate it based on
obsidian-nvim/obsidian.nvim
Secondary changes
Add
deps/
directory to.gitignore
PR Checklist
CHANGELOG.md
is updatedREADME.md
filemake chores
(for style, lint, types, and tests)